Improve types for `and` and `or`

jmurphyau / ember-truth-helpers

Ember HTMLBars Helpers for {{if}} & {{unless}}: not, and, or, eq & is-array

MIT License

706 stars 95 forks source link

Improve types for `and` and `or` #196

Closed wagenet closed 1 year ago

SergeAstapov commented 1 year ago

@wagenet Thank you for doing this! This is great improvement over what we had before and over other attempts as this PR tackles the types holistically!

FYI I've moved tsconfig.json used for type tests to type-tests folder as without it build:types command generated declarations/src and declarations/type-tests folder hence consuming app couldn't find them (as types end up in nested src folder)

SergeAstapov commented 1 year ago

CI is green now! I'll merge this now and then release as v4.0.2 bugfix

Big thanks @wagenet for these improvements!

Techn1x commented 1 year ago

thanks a bunch. The types in 4.0.2 work a treat!