Failing test for or helper with fallback

jmurphyau / ember-truth-helpers

Ember HTMLBars Helpers for {{if}} & {{unless}}: not, and, or, eq & is-array

MIT License

706 stars 95 forks source link

Failing test for or helper with fallback #198

Closed SergeAstapov closed 1 year ago

SergeAstapov commented 1 year ago

@wagenet @NullVoxPopuli here is an issue that originally pushed into direction of using smth like #191, and there is #193 for the exact same problem.

I'm not sure if it's something we could (and if we should) tackle with types only. Opened PR instead of an issue to show the actual code that fails + a reproduction.

@wagenet @NullVoxPopuli from your perspective, is it worth to publish #196 knowing this shortcoming?

wagenet commented 1 year ago

I'll give it a look

SergeAstapov commented 1 year ago

this is fixed in #199