search

jmurphyau / ember-truth-helpers

Ember HTMLBars Helpers for {{if}} & {{unless}}: not, and, or, eq & is-array
MIT License
706 stars 95 forks source link

Remove unnecessary `template-registry.js` export in `rollup.config.mjs` #203

Open mkszepp opened 7 months ago

mkszepp commented 7 months ago

This is fixing a warning while rollup & also a unnecessary file on npm

../ember-truth-helpers prepare: [js] (!) Generated an empty chunk
../ember-truth-helpers prepare: [js] "template-registry"

grafik

SergeAstapov commented 2 weeks ago

@mkszepp this is not correct change as you would not be able to do import type EmberTruthRegistry from 'ember-truth-helpers/template-registry'; in the consumer app or addon

mkszepp commented 2 weeks ago

@SergeAstapov i don't agree... the file in dist/template-registry is empty like you see in screenshot...

The import is only for typing and typing is using only file of declaration/template-registry

The rule in package.json makes possibile to use it, you don't need it to add it in rollup file