search

jmurphyau / language-ember-htmlbars

Other
5 stars 2 forks source link

Package breaks default HTML comment keybinding #8

Closed dcalhoun closed 7 years ago

dcalhoun commented 9 years ago

When language-ember-htmlbars is enabled, the "Editor: Toggle Line Comments" command no longer works for any file ending with .html. This includes files with multiple file endings (e.g. – .html.erb).

Behavior

⌘ + /

Expected Outcome

<!--  -->

Current Outcome

{{!--  --}}

Environment

fayimora commented 8 years ago

ping @jmurphyau

ajordon commented 8 years ago

bump @jmurphyau

cdelsoin commented 8 years ago

bump @jmurphyau

RealWeeks commented 8 years ago

@jmurphyau bump

jmurphyau commented 8 years ago

over 1 year and I finally start looking into this.. That's very slack of me..

I can't reproduce this.. When I try these steps on a file that ends in .html, with either Ember or HTML as the language, I get /* */ for the comments

gaand commented 8 years ago

@jmurphyau I just installed this (version 0.3.0) in atom 1.10.2 and prior to installation I get

<!-- -->

and after

{{! }}

when I highlight a line and press Ctrl-/ (I'm running atom on Debian).

The same if I disable and then re-enable. I'm using the 404.html from a rails 4 app to test.

cafreeman commented 7 years ago

bump @jmurphyau Just ran into the same issue :(