hw05 ready for grading

[jmurthy12]

Hello,

My Homework 05 is ready to be reviewed and here is the Link : https://github.com/jmurthy12/STAT545-hw-murthy-janani/tree/master/hw05

SHA: cbdfc2f

Gapminder exploration .md file: https://github.com/jmurthy12/STAT545-hw-murthy-janani/blob/master/hw05/hw05.md

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

Thanks, Janani.

[navysealtf9k]

Hi @jmurthy12 Here are some of my thoughts on your homework assignment;

Code structure:

• Repo looks well organized and easy to navigate between homework submissions with subheadings for each.
• Would recommend you drop country observations first and then the levels of the factor. It would make more sense to the reader I feel.
• You performed the analysis on two different objects. Whilst that gives you the same results I believe the objective was to do it on one.
• Highly recommend using italics or underlining when switching between a question and your solution to it in your assignment. This would make it easier to differentiate between the two.

FIgures:-

• I recommend writing lines to your ggplot call one below the other. Makes it easier to read and understand.
• Finally learned how to use element_text from your code! Thank you for that.
• You incorporated different colour palettes and used of the multiplot function well in your report.

Tasks:-

• I think you called on the wrong dataset in your fct_reorder call. I am bit confused but according to your output and graph shouldn't Asia be the first factor?
• If that is the case, I think you should have assigned the data from your maxgdp$continent table to the levels of the country variable in your gapminder dataset when using the fct_reorder function.

I want to do more

• Very creative task matching president’s names to their repsective countries.
• One thing I would recommend is perhaps trying to match presidents by country using the join commands we learned from the previous class and then seeing if that would match correctly or not. I tried something similar and the problems I ran into gave me a deeper appreciation of factors!

You seemed to have put in a lot of work in this assignment and attempted all of what was asked of us and I think you did a good job of it!

[sepkamal]

Hi,

Nice work!

Factor Management:

• I like how you dropped Oceania 2 different ways. I did not realize this could be done with droplevels
• piping help keep code clean
• for your ggplot(gapminderWithoutOceaniaDropLevels... it would have been nice to use separate rows
• good naming convention to help keep track of objects

File I/O:

• Interesting, I used read/write.csv as opposed to the read/write_csv you used... apparently they are slightly different

• good use of class() and is.factor(). Always useful to double check these things.

• your answers were short and sweet

Visualization design

• again, please use multiple lines for your ggplot's
• graphs are very nice! I like your use of Rcolourbrewer
• One further suggestion would be to play around with the font sizes for axes/title
• You did a good job demonstrating the importance of specifying the plot to save, and the various save parameters

Repo:

• Very organized!
• I suggest adding a more informative name to each hw assignment for your main readme, so it is easier to know which assignment to look at in the future

Extra:

• Cool idea to look at presidents!
  • In the future might be even cooler to find a dataset online with presidents for a longer list of countries
  • Also perhaps instead of filtering gapminder by manually entering the vector of countries, you could call on country. Even better would be to use join!
  • Thanks for teaching me about factor_recode

Cheers, Sep

[ksedivyhaley]

Factor management (drop & reorder): Yes File I/O (data): Yes Visualization design: Yes File I/O (write figure): Yes Organized GitHub: Partial (see comments) Bonus (more forcats, eg relevel): Yes Reflection: Yes

Comments:

• For your repo, add “slugs” to the files, eg hw05_FactorsFigures, so you know what is in each assignment. You could also include this information in a table of contents – while having links to the homework in your README is useful, it is even more useful to know what each homework covers (and a table or bulleted list is a more compact way to include this than headers). I also recommend using subfolders in each assignment to store saved figures (hw05 is a bit crowded).
• Your homework is difficult to follow because you have repeated certain instructions (and it looks like you've repeated the data I/O task, too, with the GDP and lifeExp data), and it's hard to tell where the instructions end and your comments begin. The bit on reading and writing figures is especially confusing because I can't easily tell which figures came from which ggsave command.
• It is generally good style to start a new line after each %>%and, when using ggplot, after each +
• What happens to the levels of continent in gapminderWithoutOceania, after you have filtered but before using fct+drop() or droplevels()?
• Your x-axis is weird for the bar plots in the visualization design activity. Try using the years that actually match the data.
• I like that you've gone back to the side-by-side layout, but in this case it makes the new plot look less good because its width is "squished."

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.