Open jmurthy12 opened 7 years ago
Your main repo is easy to navigate through, with clear sectioning.
A few of your headers aren't rendered properly. I think you have to include a space after the hash symbols on headers.
The link for the markdown file of your assignment in the main repo actually links to the hw06 folder.
Lots of useful info in your HW06 README.md file!
You should use a well formatted title. It doesn't have to be the same as the file name.
It's great that you included a table of contents. You can add links to your table using syntax like this: [Data Wrangling Wrapup](#data-wrangling-wrapup)
which would render like this: Data Wrangling Wrapup
Very clear text and nicely formatted tables/ plots.
You could modify theme elements and labels in your plots to make them really sparkle.
Your functions are nice and simple. They work, but you could have developed them a little more.
It was great that you incorporated your functions written in the previous section to this part, really cool.
Perhaps your code chunk (nestedGapminderLinearFit <- nestedGapminderLinearFit %>% mutate( tidy = map( linearFit , tidy ) ))
throws an error because you are assigning a reserved function name tidy
to a variable. Try using another variable name.
You have thorough answers to all of the questions, it was fairly easy to follow your work.
However it would be nice to have a little bit more discussion on some questions in this section, to help the reader understand what you are doing.
You should proofread your work. There are a lot of small grammar mistakes.
Overall: Good job on the project. I know this was a long assignment, but there are a lot of small things you could have done to improve the final appearance of your report. The coding itself was slick and easy to follow.
-Hayden
Hi Janani,
I think that your repository is well organized and easy to navigate. I liked that you presented the assignments in “descending” order, having the most recent one at the top of the list. The initial part of your assignment file is very well organized. In my opinion, the idea of the table of contents is very good and I think you did a good job on separating the task about Writing functions from the task about working with a nested data frame by using titles. It would have been nice to have some sort of similar structure within each task to add clarity and help the reader.
Writing functions I think that you did a good job creating the functions to fit Quadratic , Robust, and Linear regressions. I liked how you started by presenting the plots before building your functions. As a suggestion, I recommend to always add a title to your plots.
Work with a nested data frame Good job applying your functions from the previous task! I think you did a very good job on this task and liked your approach for finding interesting countries and that you actually explained what happened in some of this countries at the end of your file.
Best,
Mar.
Hello,
My Homework 06 is ready to be reviewed and here is the Link : https://github.com/jmurthy12/STAT545-hw-murthy-janani/tree/master/hw06
SHA: f976ced
Gapminder exploration .md file: https://github.com/jmurthy12/STAT545-hw-murthy-janani/blob/master/hw06/hw06_data_wrangling_wrap_up.md
@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho
Thanks, Janani.