search

jmvtechnology / Clappr-Subtitle

SubRip (srt) subtitle support for the Clappr player
17 stars 11 forks source link

Subtitles don't work on some videos #9

Closed h4rpreet closed 7 years ago

h4rpreet commented 7 years ago

Hi, i added post few days ago that subtitle don't work on some videos and you asked for an example.

I sent an example video+srt file few days ago in your email.

Can you check it ? I've more examples if you need it.

Regards

tmaiadev commented 7 years ago

Hello, I did check, thank you. Already working that =) Fix will be available soon. I'll let you know.

h4rpreet commented 7 years ago

Thanks buddy

h4rpreet commented 7 years ago

any update ?

tmaiadev commented 7 years ago

Still working on it, pal. I've been pretty busy lately. Sorry

h4rpreet commented 7 years ago

I hope this will be done anytime soon, If you want i can pay you for your time to add some extra features/fixes for me.

h4rpreet commented 7 years ago

Hello buddy,

If you don't have time to fix it, can you tell me what is the issue ? So i can ask someone else to fix it. We can't even find the problem actually, if you can tell where is the problem , we might fix it and contribute also here.

Thanks.

tmaiadev commented 7 years ago

It's very likely to be something in the parseSubtitle method. Not sure what though. It's open, feel free to ask anyone to contribute, I'll be more more than happy to accept the contribution =)

tmaiadev commented 7 years ago

I believe it is now fixed.