search

jmw86069 / venndir

Venn diagrams with directionality (concordance), optional display of items inside the figure, text Venn diagrams
https://jmw86069.github.io/venndir
Other
6 stars 0 forks source link

persist error, meet error 'length = 2' in coercion to 'logical(1) #9

Closed LynnGoodnight closed 2 months ago

LynnGoodnight commented 2 months ago 
          hi, thanks for your reply. sorry for my late reply. i re-install your package and test the same code agian
setlist_dir <- make_venn_test(100, 3, do_signed=TRUE)
setlist_dir
venndir(setlist_dir, overlap_type="each")
venndir(setlist_dir)
> venndir(setlist_dir)
Error in c("factor", "ordered") %in% class(i) && TRUE %in% honorFactor : 
  'length = 2' in coercion to 'logical(1)'

this error still persist.

sessionInfo() R version 4.4.0 (2024-04-24) Platform: x86_64-pc-linux-gnu Running under: Ubuntu 22.04.4 LTS

Matrix products: default BLAS: /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.10.0 LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.10.0

locale: [1] LC_CTYPE=en_GB.UTF-8 LC_NUMERIC=C
[3] LC_TIME=en_GB.UTF-8 LC_COLLATE=en_GB.UTF-8
[5] LC_MONETARY=en_GB.UTF-8 LC_MESSAGES=en_GB.UTF-8
[7] LC_PAPER=en_GB.UTF-8 LC_NAME=C
[9] LC_ADDRESS=C LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

time zone: Etc/UTC tzcode source: system (glibc)

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] farver_2.1.2 matrixStats_1.3.0 colorspace_2.1-0
[4] venndir_0.0.32.900

loaded via a namespace (and not attached): [1] vctrs_0.6.5 ggbeeswarm_0.7.2 cli_3.6.2
[4] knitr_1.47 rlang_1.1.4 xfun_0.45
[7] colorjam_0.0.28.900 generics_0.1.3 data.table_1.15.4
[10] glue_1.7.0 htmltools_0.5.8.1 jamba_0.0.100.900
[13] fansi_1.0.6 scales_1.3.0 rmarkdown_2.27
[16] grid_4.4.0 evaluate_0.23 munsell_0.5.1
[19] tibble_3.2.1 fastmap_1.2.0 yaml_2.3.8
[22] lifecycle_1.0.4 BiocManager_1.30.23 vipor_0.4.7
[25] compiler_4.4.0 dplyr_1.1.4 pkgconfig_2.0.3
[28] rstudioapi_0.16.0 beeswarm_0.4.0 digest_0.6.35
[31] R6_2.5.1 tidyselect_1.2.1 utf8_1.2.4
[34] pillar_1.9.0 magrittr_2.0.3 tools_4.4.0
[37] gtable_0.3.5 ggplot2_3.5.1 remotes_2.5.0

Originally posted by @LynnGoodnight in https://github.com/jmw86069/venndir/issues/8#issuecomment-2182720726

jmw86069 commented 2 months ago

Thank you for testing. This error was a regression in jamba which has been fixed in jamba version 0.0.101.900. Resolve by updating jamba:

remotes::install_github("jmw86069/jamba")

I have another version of venndir coming in the next couple days, I will add a specific requirement for jamba version 0.0.101.900 or higher. The new version of venndir will address outer labeling, mostly with proportional diagrams. Error can be caused when supplying an empty set in a proportional diagram. The update should also improve the position of outer labels in general. Just FYI.

LynnGoodnight commented 2 months ago

thank you very much. my error now be completely fixed. thanks for your wonderful work. looking forward to new version of venndir.

jmw86069 commented 2 months ago

Nice, thank you so much! I pushed another update just now, fixing some issues with proportional diagrams. I'll close this issue for now.