search

jmxtrans / embedded-jmxtrans

In process JMX metrics exporter.
MIT License
82 stars 37 forks source link

Fix AbstractOutputWriter toString() #108

Closed YannRobert closed 9 years ago

YannRobert commented 9 years ago

when calling toString() on an OutputWriter

we expect "org.jmxtrans.embedded.output...." but we get "class org.jmxtrans.embedded.output...."

this change fixes the issue

YannRobert commented 9 years ago

I just rebased the branch with jmxtrans:master GH web UI does not refresh the changeset accordingly :crying_cat_face:

YannRobert commented 9 years ago

maybe the PR needs to be reopened so that GH refresh the changeset?

@cyrille-leclerc why did you close this PR without a merge ?

cyrille-leclerc commented 9 years ago

@YannRobert the horrible force-push automatically closed the PR. I recreated it at https://github.com/jmxtrans/embedded-jmxtrans/pull/111

I am sorry for this mess.

YannRobert commented 9 years ago

ok so all those PR were automatically closed with the force push on master? that's tragic :fearful: Can't you manually reopen? I can't. Will I have to recreate all of my pending PR?

YannRobert commented 8 years ago

merged by #117