search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
179 stars 110 forks source link

GoogleWriter: using cluster default account #117

Closed evmin closed 6 years ago

evmin commented 6 years ago

Added an option of sourcing authentication token from Google Container Engine cluster.

OBS! Slight change of behaviour, the Container Engine service account takes precedence over the GOOGLE_APPLICATION_CREDENTIALS.

Documented the implications.

cyrille-leclerc commented 6 years ago

Thanks @evmin !

evmin commented 6 years ago

@cyrille-leclerc : thank you. Much appreciated. Would you have an idea when 1.2.7 might be released? The reason I am asking is that the dev teams usually uneasy with using -SNAPSHOT versions. So it is purely bureaucratic reason.

cyrille-leclerc commented 6 years ago

I have released jmxtrans-agent-1.2.7-beta-1, can you please verify that your change works as desired? https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.7-beta-1

evmin commented 6 years ago

Just done the tests - all good. Thank you! Beta is acceptable for the immediate future. Much appreciate the expediency of that promotion.

cyrille-leclerc commented 6 years ago

Thanks @evmin !