search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
179 stars 110 forks source link

Make tags to be serialized according to DogStatsD and Sysdig protocols #124

Closed ncolomer closed 6 years ago

ncolomer commented 6 years ago

Fixes jmxtrans/jmxtrans-agent#123

cyrille-leclerc commented 6 years ago

Thanks @ncolomer . I'll cut a beta release and ask the community and @jakobant if someone can test (I don't have a test prepared for Datadog).

ncolomer commented 6 years ago

@cyrille-leclerc we can easily test this beta in production too. We're using influxdata/telegraf collector agent with statsd service plugin and influxdb as storage backend.

cyrille-leclerc commented 6 years ago

Thanks @ncolomer

@ncolomer @jakobant can you please test https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.8-beta-1 ?

ncolomer commented 6 years ago

@cyrille-leclerc 1.2.8-beta-1 was deployed in production today.

We successfully declared more than one tag (in our case service and version, in addition to the default host tag) and see them as expected in our monitoring stack.

cyrille-leclerc commented 6 years ago

Thanks @ncolomer, I am releasing 1.2.8 at the moment.

ncolomer commented 6 years ago

Great! Thanks @cyrille-leclerc for your reactivity on this!