search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
179 stars 110 forks source link

Changed the maven compiler flag to use the release flag instead to co… #157

Closed endoplasmicR closed 3 years ago

endoplasmicR commented 3 years ago

…rrectly set the JDK bootclasspath

endoplasmicR commented 3 years ago

@cyrille-leclerc @billonahill Was still running into the JDK error since the artifact is build using JDK15. I have verified this build locally using mvn clean install see https://stackoverflow.com/questions/43102787/what-is-the-release-flag-in-the-java-9-compiler for the release flag usage

cyrille-leclerc commented 3 years ago

Thank you very much @endoplasmicR . Please test https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.11-rc-4

endoplasmicR commented 3 years ago

Thank you very much @endoplasmicR . Please test https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.11-rc-4

hi, @cyrille-leclerc I have tested it out and it is looking good. can you please create a minor version release?

Thank you.

cyrille-leclerc commented 3 years ago

Thanks @endoplasmicR . Here is the release: https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.11