search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
178 stars 110 forks source link

Add IO Resource Framework #69

Closed cyrille-leclerc closed 8 years ago

cyrille-leclerc commented 8 years ago

Add an IO resource framework inspired by org.springframework.core.io.Resource to handle configuration files

cyrille-leclerc commented 8 years ago

@kerlandsson would you have the time to look at it?

Once I merge this, I'll look at using the same framework for the UrlOrFilePropertiesLoader and refactor org.jmxtrans.agent.properties.UrlOrFilePropertiesLoader#isClassPathSpec(), org.jmxtrans.agent.properties.UrlOrFilePropertiesLoader#isUrl(), org.jmxtrans.agent.properties.UrlOrFilePropertiesLoader#loadFromClasspath()...

kerlandsson commented 8 years ago

I think this looks great @cyrille-leclerc! Thanks for putting in the effort. As you can see I have added some minor stuff as line comments.

If you want I can refactor UrlOrFilePropertiesLoader myself after you have merged this.

cyrille-leclerc commented 8 years ago

@kerlandsson please review my changes.

cyrille-leclerc commented 8 years ago

@kerlandsson please review my changes and comments.