Replace UrlOrFilePropertiesLoader by a PropertiesLoader based on the IO Resource Framework

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.

MIT License

179 stars 110 forks source link

Closed cyrille-leclerc closed 8 years ago

cyrille-leclerc commented 8 years ago

Replace UrlOrFilePropertiesLoader by a PropertiesLoader based on our new IO Resource Framework
Add log messages
Use properties loader in the test src/test/tomcat

cyrille-leclerc commented 8 years ago

@kerlandsson can you please review?

kerlandsson commented 8 years ago

@cyrille-leclerc This looks great! Since I couldn't find something major to comment on I did some nit-picking above :).

cyrille-leclerc commented 8 years ago

@kerlandsson here is an updated version with your recommendations.

kerlandsson commented 8 years ago

Looks good! :+1: