search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
178 stars 110 forks source link

Added Experimental InfluxDb output writer #79

Closed kerlandsson closed 8 years ago

kerlandsson commented 8 years ago

Output writer for InfluxDb.

A bit experimental since I'm not an Influx expert. However, the changes do not affect anything else so should be safe to merge and let others test it.

Restricted to measurements with one field since I could not come up with a good way to support multiple fields with how we structure queries and writers.

For more information about configuration and how it works see the updated README.md.

@cyrille-leclerc If you have the time, I would appreciate a review.

Fixes #24

cyrille-leclerc commented 8 years ago

@kerlandsson I won't have time to review in the next 3 week, sorry :-(

kerlandsson commented 8 years ago

@cyrille-leclerc Ok, no worries! I'm considering merging this anyways in hope to get someone to test it. It's listed as experimental in the readme so we are still free to change its behavior. Is that OK with you?

cyrille-leclerc commented 8 years ago

I did not test, I just read the code and I like it!

Thanks @kerlandsson !

cyrille-leclerc commented 8 years ago

Perfect!

On Wed, May 25, 2016 at 1:46 PM, Kristoffer Erlandsson < notifications@github.com> wrote:

@cyrille-leclerc https://github.com/cyrille-leclerc Ok, no worries! I'm considering merging this anyways in hope to get someone to test it. It's listed as experimental in the readme so we are still free to change its behavior. Is that OK with you?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/jmxtrans/jmxtrans-agent/pull/79#issuecomment-221549365

Cyrille Le Clerc Director of Product Management email & gtalk : cleclerc@cloudbees.com / mob: +33-6.61.33.69.86 / skype: cyrille.leclerc CloudBees, Inc www.cloudbees.com

https://www.cloudbees.com/jenkins-certification http://www.jenkinsworld.com/

kerlandsson commented 8 years ago

@cyrille-leclerc Thank you for taking the time to read the code. I have implemented your suggestions - closing the connection and put the Clock externally and am reusing it in GraphiteUdpOutputWriter where I had the same setup. I will merge this now.