search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
178 stars 110 forks source link

Added ability to disable the InfluxDbOutputWriter #94

Closed claudiouzelac closed 7 years ago

claudiouzelac commented 7 years ago

This pull request provides the ability to disable the InfluxDbOutputWriter like its Graphite brethren.

gehel commented 7 years ago

That's a question for @cyrille-leclerc to answer, but since it looks like there are at least 2 output writers implementing the ability to disable themselves, should it be something moved to AbstractOutputWriter instead of duplicating it? I am myself suspicious of having a disabled configuration option, this looks like something to be implemented outside of jmxtrans agent itself, but since it is already present in the GraphiteOutputWriter...

claudiouzelac commented 7 years ago

I was in a similar boat. At the company that I am working with, the use case for disabling this is needed for local development but we would like to enable it for deployment to environments (dev, qa, prod) hence this PR. Please advise and I happily make those changes.

claudiouzelac commented 7 years ago

Bumping this to see if there are any action items?

cyrille-leclerc commented 7 years ago

Sorry @bowlofstew , I missed this PR. Can you please test the snapshot version and confirm us that we can release?

claudiouzelac commented 7 years ago

Thanks, will do.

claudiouzelac commented 7 years ago

Looks good to me.