search

jmxtrans / jmxtrans-agent

Java Agent based JMX metrics exporter.
MIT License
179 stars 110 forks source link

[#91] InfluxDB - Decimal number formatting (float, double and BigDecimal) #95

Closed cyrille-leclerc closed 7 years ago

cyrille-leclerc commented 7 years ago

Work on #91 Add test case to check the output for a big float

cyrille-leclerc commented 7 years ago

I found in the official java client https://github.com/influxdata/influxdb-java/blob/influxdb-java-2.5/src/main/java/org/influxdb/dto/Point.java#L321

NumberFormat numberFormat = NumberFormat.getInstance(Locale.ENGLISH);
numberFormat.setMaximumFractionDigits(MAX_FRACTION_DIGITS);
numberFormat.setGroupingUsed(false);
numberFormat.setMinimumFractionDigits(1);
cyrille-leclerc commented 7 years ago

@kerlandsson & @BriacRONDI can you please review this code and, if possible, test?

kerlandsson commented 7 years ago

@cyrille-leclerc https://github.com/cyrille-leclerc sorry but I have just changed jobs and have currently no time nor environment to work on this, sorry :(.

On Feb 16, 2017 11:02, "Cyrille Le Clerc" notifications@github.com wrote:

@kerlandsson https://github.com/kerlandsson & @BriacRONDI https://github.com/BriacRONDI can you please review this code and, if possible, test?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jmxtrans/jmxtrans-agent/pull/95#issuecomment-280287163, or mute the thread https://github.com/notifications/unsubscribe-auth/AD-iads_CGczzP092W8M2Bl-oc0e_C0Oks5rdB7EgaJpZM4MBi74 .