search

jmxtrans / jmxtrans

jmxtrans
MIT License
1.71k stars 503 forks source link

Axibase Time Series Database Writer #418

Open rodionos opened 8 years ago

rodionos commented 8 years ago

We'd like to implement and submit a PR for Axibase Time Series Database Writer, bot for tcp/udp and http/json protocols. Is jmxtrans open to accept new writers? If accepted, we'll be maintaining the writer to ensure it is in sync with server-side protocol and API changes.

http://axibase.com/products/axibase-time-series-database/

Thanks,

Sergei

gehel commented 8 years ago

I'm more than happy to accept new writers. If the code is clean and tested, the pull request will probably be merged fairly fast.

If your writer does not add new dependencies, add it to the core output writers module. Else, create a new module for it.

Looking forward to your PR!

rodionos commented 8 years ago

Great, thanks. We have a well tested API client which we would to use to minimize the amount of low level code. Is the dependency list manageable for you https://github.com/axibase/atsd-api-java/blob/master/pom.xml?

gehel commented 8 years ago

Any dependencies are manageable. I'd just like to make sure that the core of JmxTrans has few dependencies (it has far too many at the moment) and that core outputwriters also have as few dependencies as possible. Adding a separate module with half of the world as dependencies is not an issue for me.

The only problematic dependency that I see in the list is logback-classic, which will clash with the log4j that we use. But that can be managed with an exclusion...