[feat/#380] 시작화면 UI 구현 - [merged] #23

Closed jmxx219 closed 1 month ago

In GitLab by @btothey99 on Sep 11, 2024, 12:44

Merges feat/fe-S11P21A701-380-ui-startpage -> dev-fe

주요 변경사항

로고
카카오, 구글 로그인 버튼, 비회원

리뷰 요청사항

[x] MR Approve

➕ 지라 링크

S11P21A701-380

In GitLab by @btothey99 on Sep 11, 2024, 12:44

requested review from @breakking

In GitLab by @breakking on Sep 11, 2024, 14:20

Commented on frontend/melting/src/apis/authApi.ts line 6

사용자 타입을 따로 빼는게 좋을거 같아요 다른 컴포넌트에서 많이 사용할거 같은데 가령 마이페이지나 아니면 store 같은 곳에서 쓸거 같음

In GitLab by @breakking on Sep 11, 2024, 14:20

Commented on frontend/melting/src/components/auth/LoginForm.tsx line 12

OauthButton으로 빼고 prop로 넘기는건 어떤가요???

In GitLab by @btothey99 on Sep 11, 2024, 14:21

Commented on frontend/melting/src/apis/authApi.ts line 6

임시로 일단 만들어둔거라 수정가능합니다 types 폴더에 만들어놓겠습니다

In GitLab by @btothey99 on Sep 11, 2024, 14:23

Commented on frontend/melting/src/components/auth/LoginForm.tsx line 12

prop으로 어떻게 넘긴다는 것인지 모르겠습니다

버튼 클릭하면 바로 백엔드로 요청들어가고 회원가입한 사용자라는 게 백엔드에서 응답 들어오면 메인페이지로 이동하고 아니라면 회원가입 페이지로 이동하게됩니다.

button 이벤트로 처리하려고 했는데 prop이 어디로 어떻게 들어가는걸까요??

In GitLab by @btothey99 on Sep 11, 2024, 14:41

Commented on frontend/melting/src/apis/authApi.ts line 6

changed this line in version 2 of the diff

In GitLab by @btothey99 on Sep 11, 2024, 14:41

added 2 commits

410df6ce - rafactor: auth, user type 생성
9e60e1a9 - rename: 로그인 버튼 컴포넌트로 변경

Compare with previous version

In GitLab by @btothey99 on Sep 11, 2024, 14:41

Commented on frontend/melting/src/apis/authApi.ts line 6

types에 만들어놨습니다

In GitLab by @breakking on Sep 11, 2024, 15:08

approved this merge request

In GitLab by @breakking on Sep 11, 2024, 15:08

marked the checklist item MR Approve as completed

In GitLab by @breakking on Sep 11, 2024, 15:08

mentioned in commit 5b2842e84078cce08a5d0e972c81925ed7a01f0f

In GitLab by @breakking on Sep 11, 2024, 15:13

Commented on frontend/melting/src/components/auth/LoginForm.tsx line 12

interface OauthButtonProps {
  imgName : String,
  buttionText : String
  ...
}

function OauthButton(props : OauthButtonProps) {
  return 
  <button className="w-full py-3 flex items-center justify-center relative bg-[#FEE500] text-black font-bold rounded-full transition-colors h-14">
  <img src="/images/logo/kakao_logo.png" alt="카카오 로고" className="absolute left-4 w-4 h-4" />
  <p className="ml-6">{props.buttionText}</p>
</button>

}

jmxx219 / Melting