[feat/#449] 회원 관련 API 구현 - [merged] - Githubissues

jmxx219 / Melting

AI 나만의 커버곡/앨범 생성 서비스(최우수상)

0 stars 4 forks source link

[feat/#449] 회원 관련 API 구현 - [merged] #27

Closed jmxx219 closed 1 month ago

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 09:04

Merges feat/be-S11P21A701-449-memberapi -> dev-be

주요 변경사항

닉네임 중복 검사
회원 정보 초기화, 수정, 조회
로그아웃

리뷰 요청사항

[x] 닉네임 중복 검사
[x] 회원 정보 초기화
[x] 회원 정보 수정
[x] 회원 정보 조회
[x] 로그아웃

➕ 지라 링크

S11P21A701-449

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 09:04

requested review from @yeomky98

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 09:43

added 1 commit

fd42496e - refactor: customoauth2user id 필드 추가 및 member 리팩토링

Compare with previous version

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:48

Commented on backend/src/main/java/com/dayangsung/melting/domain/member/service/MemberService.java line 43

RuntimeException보다는 NotFoundMember exception을 만드는게 좋을 것 같습니다.

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:50

marked the checklist item 닉네임 중복 검사 as completed

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:52

marked the checklist item 회원 정보 초기화 as completed

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:52

marked the checklist item 회원 정보 수정 as completed

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:52

marked the checklist item 회원 정보 수정 as incomplete

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:52

marked the checklist item 닉네임 중복 검사 as incomplete

jmxx219 commented 2 months ago

In GitLab by @antlf1104 on Sep 12, 2024, 09:52

marked the checklist item 회원 정보 초기화 as incomplete

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:58

Commented on backend/src/main/java/com/dayangsung/melting/domain/member/controller/MemberController.java line 48

메서드명 checkNickname이나 validateNickname은 어떤가요?

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:58

Commented on backend/src/main/java/com/dayangsung/melting/domain/member/entity/Member.java line 51

init으로 줄여쓰시나요? 저도 init 쓸 일 있으면 줄여 쓰려고 여쭤봅니다

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:58

고생 많으셨습니다!

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:59

marked the checklist item 닉네임 중복 검사 as completed

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:59

marked the checklist item 회원 정보 초기화 as completed

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:59

marked the checklist item 회원 정보 수정 as completed

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:59

marked the checklist item 회원 정보 조회 as completed

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 09:59

marked the checklist item 로그아웃 as completed

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 10:06

added 1 commit

1c25d828 - fix: 회원 정보 수정 시 null check

Compare with previous version

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 11:01

Commented on backend/src/main/java/com/dayangsung/melting/domain/member/entity/Member.java line 51

줄여서 썼을 때 구분이 잘 안되는것들은 풀네임으로 쓰는게 좋지만 init처럼 많이 사용하는 것들은 줄여서 쓰는것도 괜찮다고 생각합니다 :smile:

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 11:02

Commented on backend/src/main/java/com/dayangsung/melting/domain/member/service/MemberService.java line 43

추후에 커스텀 예외처리 하겠습니다 :thumbsup:

jmxx219 commented 2 months ago

In GitLab by @fview on Sep 12, 2024, 11:05

added 1 commit

bb96b584 - rename: 닉네임 중복 검사 메서드명 변경

Compare with previous version

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 12:05

approved this merge request

jmxx219 commented 2 months ago

In GitLab by @yeomky98 on Sep 12, 2024, 12:05

mentioned in commit 0ecdbe8479c6f89a8dbbd845cd706c55882d7b60