search

jn-jairo / laravel-ngrok

Share Laravel application with ngrok.
MIT License
89 stars 12 forks source link

I corrected the syntax for host rewrites. #3

Closed roblesterjr04 closed 5 years ago

roblesterjr04 commented 5 years ago

the syntax was --host-header='site' 'port' but should be --host-header=rewrite 'site':'port'

jn-jairo commented 5 years ago

@roblesterjr04 As far as I know the two commands are compatible. Did you have a problem with the current command? If so could you explain so I can simulate the error?

roblesterjr04 commented 5 years ago

There was no error. It simply didn’t forward the correct host name. It still forwarded the local host. After correcting the syntax it forwarded the app host correctly. On Jun 16, 2019, 11:02 AM -0400, Jairo Correa notifications@github.com, wrote:

@roblesterjr04 As far as I know the two commands are compatible. Did you have a problem with the current command? If so could you explain so I can simulate the error? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jn-jairo commented 5 years ago

Are you running inside vagrant with homestead, in the host or in another environment? I tried many environments and in all it is working, I want to know what is the difference in your case, I don't see a problem in change the command syntax, just want to understand why that difference to be sure that this change will not break the package for the others.

roblesterjr04 commented 5 years ago

I was running it from my machine, but the app was coming from a vagrant.

I simply made the syntax match that which is documented in the post I shared. On Jun 17, 2019, 4:08 PM -0400, Jairo Correa notifications@github.com, wrote:

Are you running inside vagrant with homestead, in the host or in another environment? I tried many environments and in all it is working, I want to know what is the difference in your case, I don't see a problem in change the command syntax, just want to understand why that difference to be sure that this change will not break the package for the others. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jn-jairo commented 5 years ago

@roblesterjr04 you should run this and the other artisan commands inside vagrant