jnanaswaroop
commented
1 week ago CSV Content Preview
Title,Description,Merge Request ID,GitLab MR URL,Created At,Updated At,Closed At,Merged At,Author,Source Branch,Target Branch,State,Merged By,Assignees,Reviewers,Project ID,Closed By,Labels,Head SHA,Base SHA,Should Remove Source Branch,Approvals Before Merge,Reviewers Comments
vass_379_mv_vendor_share_speed,Small speed boost to a mat view. Consider providers that have `rebate_tracking_enabled`.,340826268,https://gitlab.com/lumere/phapp/-/merge_requests/11742,2024-11-05T21:45:26.323Z,2024-11-05T22:37:20.492Z,,,Michael Jaskiewicz,vass_379_mv_vendor_share_speed,master,opened,NA,Michael Jaskiewicz,"Nathan Kessler, May Hong",17258897,NA,NA,7dbb58bf250c992999f4d84c83edda55f17abc86,7e974aa130927a006069cc404a791a0b90c80864,,,No comments
VASS-343 temp fix for voting,"https://workflow.ghx.com/browse/VASS-343
Temporary quick fix for bug preventing voting reminders.
To verify:
1. Pull branch
2. Go here: http://localhost:8000/projects/28689/voting/8538/notify/
3. Click Send reminder
Expect: voting reminders are sent out in console",340815232,https://gitlab.com/lumere/phapp/-/merge_requests/11741,2024-11-05T20:28:06.885Z,2024-11-05T20:36:04.721Z,,2024-11-05T20:36:04.770Z,John Morris,VASS-343_fix_reminders,master,merged,John Morris,Michael Katzenbach,NA,17258897,NA,Kaleidocode,58c0915be2eb761f41278e36012d5ae0f50b37a7,b090d2eb7f28dfd52904ec78f7f3a5ee8770060b,True,,Michael Katzenbach: :ship:
VASS-342-fix resort,"# Ticket
https://workflow.ghx.com/browse/VASS-342
# Description
This MR fixes the functionality when a use re-filters a page and a sort key is already set
# Changes
`ContractsHeaderRow`
* remove unused parameter
`actions`
* Pass getters in
* Instead of using the index, just find the index based on the sort key
# Testing
* Pull branch, use latest
* Go to the rebates page, and the `All` tab
* Results should load. Click a header that changes the order enough so you'll be able to confirm the changes work
* Hit filter again -- results should stay in the same order they were previously
# Notes",340805661,https://gitlab.com/lumere/phapp/-/merge_requests/11740,2024-11-05T19:29:16.344Z,2024-11-05T19:31:53.569Z,,,Nathan Kessler,VASS-342,master,opened,NA,Nathan Kessler,May Hong,17258897,NA,NA,4855cb6e1bedb502fd4a2e966dec264b0a395ae5,9d609a9d66628892af747e0e8684f6ea3fc895eb,,,No comments
vass_367_all,Silly ticket to be able to kick off rebates classification jobs.,340531164,https://gitlab.com/lumere/phapp/-/merge_requests/11739,2024-11-04T22:41:37.353Z,2024-11-05T18:35:13.827Z,,2024-11-05T18:35:13.879Z,Michael Jaskiewicz,vass_367_all,master,merged,Michael Jaskiewicz,Michael Jaskiewicz,"Nathan Kessler, May Hong",17258897,NA,NA,c5020b4c243ff6938a7bf79c41419bb20f8cc721,b090d2eb7f28dfd52904ec78f7f3a5ee8770060b,True,,Nathan Kessler: it's always fun learning about why the job doesn't show up in the list on the job status page lol
VASS-328-route to details page,"# Ticket
https://workflow.ghx.com/browse/VASS-328
# Description
This MR is to make it so when we save a new contract, it routes us to the contract details page instead of changing it to edit route. The previous logic didn't really set the contract in the state, so it was possible to create duplicate contracts instead of editing it
# Changes
`ContractEdit`
* Don't push anything to the router anymore, just go to the contract edit page
# Testing
* Pull branch, use latest
* Go to the rebates page, and hit create contract
* Fill in the form, submit
* The page should route to the contract details page
# Notes",340530358,https://gitlab.com/lumere/phapp/-/merge_requests/11738,2024-11-04T22:31:11.267Z,2024-11-05T17:48:24.127Z,,,Nathan Kessler,VASS-328,master,opened,NA,Nathan Kessler,May Hong,17258897,NA,CODA,c170bfec14cae76c6a7f2ca4daedf4f7a9d4beb3,b090d2eb7f28dfd52904ec78f7f3a5ee8770060b,,,"May Hong: This works when creating contract but users won't redirect when saving after editing contract
Nathan Kessler: should be fixed now"
Draft: Vass 336,,340528995,https://gitlab.com/lumere/phapp/-/merge_requests/11737,2024-11-04T22:16:13.151Z,2024-11-05T16:52:25.357Z,,,Michael Katzenbach,vass-336,master,opened,NA,Michael Katzenbach,NA,17258897,NA,Kaleidocode,dbe9e3196f0a84a741eaa456a5ad497d211b3a4b,b090d2eb7f28dfd52904ec78f7f3a5ee8770060b,,,No comments
VASS-359-add pill,"# Ticket
https://workflow.ghx.com/browse/VASS-359
# Description
This MR adds a pill for the rebated amount
# Changes
`TrackedContractsRow`
* Add pill
# Testing
* Pull branch, use latest
* Go to the rebates tab, the pill exists
# Notes",340519118,https://gitlab.com/lumere/phapp/-/merge_requests/11736,2024-11-04T20:51:38.246Z,2024-11-05T17:34:20.805Z,,2024-11-05T17:34:20.838Z,Nathan Kessler,VASS-359,master,merged,Nathan Kessler,Nathan Kessler,May Hong,17258897,NA,CODA,6906dfaa06b9d2451f6c3349709ee9093ffd4a38,f17cfaca5af6e8dd54aee12caca47ec1f3bcb7c0,True,,May Hong: lgtm!
Vass 247 - Rebate earning overview ribbon,"# Ticket
https://workflow.ghx.com/browse/VASS-247
# Description
The goal of this MR is to add a ribbon to the contract overview tab.
# Changes
`rebates/actions.js`, `ContractDetail.vue`, `DetailsFilter.vue`, `rebates/urls.js`
- Pass query parameters to rebates api to filter query
`ContractOverview.vue`
- add `OverviewRibbon` component
`OverviewRibbon.vue`
- Computed properties use rebates annotations instead of contract's because contract annotations take a single start and end date, which is not suitable for periods filter. Rebate annotations take a list of periods.
`rebates.models.RebateQuerySet`
- `calculated_rebates`: Similar to the annotation of contract queryset but allows filtering by a list of periods.
- `aggregated_received_rebates`: Returns a list of pairs of rebate amount and date entered. This is needed for the tooltip on the ribbon. The total received amount is calculated in the component. This also filters by a list of periods.
`rebates/api_views.py`
- `RebatesContractAPI`: Add `closest_period_end_date` annotation to the contract instance. This is used for _Days until next period close_ in the ribbon.
- `RebatesAPI`
- Process the period parameter into a usable format
- Add new annotations
`rebates.serializers.RebateSerializer`
- Add fields for new annotations
# Testing
1. Pull branch
2. Go to http://localhost:8000/rebates/#/contract/1/overview
3. Check the ribbon -- you can try filtering periods to verify the periods parameter works",339174921,https://gitlab.com/lumere/phapp/-/merge_requests/11735,2024-11-01T20:56:53.821Z,2024-11-04T21:25:28.012Z,,2024-11-04T21:25:28.043Z,May Hong,VASS-247,master,merged,May Hong,May Hong,Nathan Kessler,17258897,NA,CODA,407c4e0ec0ab8620b833f5ea089dcacaa505ce5f,30f134bcab2bab9ec1890c4bc32850c59bfe16b9,True,,"May Hong: @nkessler I updated the ribbon component using `aggregatesRibbon` but I couldn't get the tooltip without modifying the existing one. Let me know how you think!
Nathan Kessler: Love it"
Vass 313 cookies,"https://workflow.ghx.com/browse/VASS-313
Going to set cookies as json rather than signing.
Using a cookie extension, verified on [deployed server](https://phapp-vass313c.lumere.sdm.network/):
mocked out the accessing the values:
In [1]: import json
In [2]: json.loads(""{\""user_id\"": 270\054 \""user_type\"": \""S\""\054 \""is_staff\"": true\054 \""google_analytics_enabled\"": false\054 \""ph_env\"": \""lumere-dev\""\054 \""tz\"": \""US/Central\""\054 \""version\"": \""3\""}"")
Out[2]:
{'user_id': 270,
'user_type': 'S',
'is_staff': True,
'google_analytics_enabled': False,
'ph_env': 'lumere-dev',
'tz': 'US/Central',
'version': '3'}
In [3]: value = json.loads(""{\""user_id\"": 270\054 \""user_type\"": \""S\""\054 \""is_staff\"": true\054 \""google_analytics_enabled\"": false\054 \""ph_env\"": \""lumere-dev\""\054 \""tz\"": \""US/Central\""\054 \""version\"": \""3
...: \""}"")
In [4]: print(value.get('user_id'))
270
In [5]: print( value.get('user_type'))
S
```",339166900,https://gitlab.com/lumere/phapp/-/merge_requests/11734,2024-11-01T19:47:45.592Z,2024-11-01T20:06:15.471Z,,2024-11-01T20:06:15.520Z,John Morris,VASS-313_cookies,master,merged,John Morris,Michael Katzenbach,NA,17258897,NA,Kaleidocode,7c16de8b4d572a824b55275ff970c6bd7e8878d5,30f134bcab2bab9ec1890c4bc32850c59bfe16b9,True,,Michael Katzenbach: Looks good. Hope it works :fingers_crossed:
"VASS-304-placeholders, z-index","# Ticket
https://workflow.ghx.com/browse/VASS-304
# Description
This MR fixes some placeholder / default values, as well as fixing an issue with the z-index of our status multiselect dropdown being less than the z-index of the active page selected in the paginator, causing the menu to be underneath the paginator
# Changes
`AllFilter`
* Add z-index
* Note that this also adds the selector for `.multiselect`, this is also a part of https://gitlab.com/lumere/phapp/-/merge_requests/11732 so it shouldn't be recognized as a change once that gets merged
`TrackedFilter`
* Set defaults of 0 for a couple fields, so that we are selecting the correct default value
`getters`
* Change default options for status and service lines
`consts`
* Change default option for refresh period
# Testing
* Pull branch, use latest
* Go to the rebates tab, filters should have placeholders now
* Go to drafts, select Draft as the status and filter so there is only one result (or Tracking)
* The dropdown menu should now be on top of the paginator
# Notes",339164002,https://gitlab.com/lumere/phapp/-/merge_requests/11733,2024-11-01T19:19:32.199Z,2024-11-05T17:37:38.330Z,,2024-11-05T17:37:38.377Z,Nathan Kessler,VASS-304,master,merged,Nathan Kessler,Nathan Kessler,May Hong,17258897,NA,CODA,c77c8ca53e09c7b6693e2b125ee0cf5b989b5d9f,30f134bcab2bab9ec1890c4bc32850c59bfe16b9,True,,May Hong: lgtm!
For a full download, click here.
Download MR Migration Logs using below link
Download CSV Log