jnanaswaroop / migration_final

Enlightening healthcare since 2012
0 stars 0 forks source link

Ph 23410 md5 key - [merged] #56

Closed jnanaswaroop closed 2 weeks ago

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 11, 2024, 22:30

_Merges ph_23410_md5key -> master

To join between the data_prep.raw_ccx table, I need some kind of key since the CCX uses item_start_date, item_end_date, uom, manufacturer_part_number, contract_number, organization_eid, vendor. This kind of key is slow to join against so I want to add an MD5 hashed version of the columns in question.

The deployment was also broken given the switch to kaniko.

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 11, 2024, 22:37

added 1 commit

Compare with previous version

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 11, 2024, 22:57

added 1 commit

Compare with previous version

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 11, 2024, 22:59

added 1 commit

Compare with previous version

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 11, 2024, 23:01

added 1 commit

Compare with previous version

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 11, 2024, 23:17

requested review from @onmay16 and @nkessler

jnanaswaroop commented 5 months ago

In GitLab by @nkessler on Jun 12, 2024, 00:52

is there a reason to hash the columns instead of just using a uid? it seems like the process to hash columns instead of just using the uid would be slower

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 12, 2024, 21:33

The whole objective here is to join from my contract table to data_prep.raw_ccx.

The data_prep.raw_ccx table brings in all the raw data rows from all the files.

jnanaswaroop commented 5 months ago

In GitLab by @nkessler on Jun 12, 2024, 22:25

gotcha -- makes sense. just curious here if nulls in any of those field will throw a wrench into this at all. if not i'll approve

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 13, 2024, 01:32

Those fields should never be null. I confirmed with CCX and in the contract table. We do have some nulls in data_prep.raw_ccx but they never made it out of that table. I'm confirming w/ CCX right now what's wrong.

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 13, 2024, 19:08

Confirmed with CCX. The rows with nulls are mistakes on their end and are to be ignored.

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 14, 2024, 00:58

enabled an automatic merge when all merge checks for 7802bab030d81f65ede42021acb0b5c0327999d9 pass

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 14, 2024, 01:04

Nate, need an approval.

jnanaswaroop commented 5 months ago

In GitLab by @nkessler on Jun 14, 2024, 01:15

approved this merge request

jnanaswaroop commented 5 months ago

In GitLab by @mjaskiewicz1 on Jun 14, 2024, 01:15

mentioned in commit a7b034b30cf590c7e5fafc168859cd3d3ce5a582