search

jnawk / Quart-Discord

Discord OAuth2 extension for Quart. An Easier implementation of "Log In With Discord".
MIT License
22 stars 18 forks source link

Migrate from discord.py to py-cord #19

Open williamhatcher opened 2 years ago

williamhatcher commented 2 years ago

I suggest changing the requirement from discord.py to py-cord as d.py is no longer being maintained.

Note: py-cord is close to releasing a 2.0 version which has breaking changes, but their current PyPi version should be a drop-in replacement for d.py

shahriyardx commented 2 years ago

Not everyone use pycord. Some uses nextcord. So if you want pycord instead of discord.py then you can create a fork > modify files and install from your fork

williamhatcher commented 2 years ago

Why not use extras to allow people to use any of the three?

From: Md Shahriyar Alam @.> Sent: Wednesday, December 29, 2021 5:48:41 AM To: jnawk/Quart-Discord @.> Cc: williamhatcher @.>; Author @.> Subject: Re: [jnawk/Quart-Discord] Migrate from discord.py to py-cord (Issue #19)

Not everyone use pycord. Some uses nextcord. So if you want pycord instead of discord.py then you can create a fork > modify files and install from your fork

— Reply to this email directly, view it on GitHubhttps://github.com/jnawk/Quart-Discord/issues/19#issuecomment-1002556534, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF3WBO2BYJVUXLCBRJ4GCRTUTLYRTANCNFSM5K3GHY4Q. You are receiving this because you authored the thread.Message ID: @.***>

jnawk commented 2 years ago

Feel free to submit a PR. In the 30 seconds I had to take a look, it could probably be done, but it'll take more than 30 seconds to figure out.