search

jnawk / aws-electron

Access the AWS Console using Access Keys and assumed roles.
ISC License
9 stars 3 forks source link

Tab-ception #36

Open jnawk opened 3 years ago

jnawk commented 3 years ago

It would be nice to have just the one window, or be able to have just the one window - tabs per account, with tabs per session.

mrpackethead commented 3 years ago

This would make your app, highly useable.. Being able to pop tabs/windows out into their own windows as well. So, i can have several open at the same..

Example, is having a pipeline open in one window, cloudformation in another.

jnawk commented 3 years ago

it appears Electron has a way of doing tabbed windows which is different to the 3rd party library I've adopted.

In any case, for a multitude of reasons, I need to be careful about this one - each profile currently launches in its own window, which, I think, is prerequisite for keeping the binding between the partition (essentially the browser session) and all the tabs belonging to the particular profile. I hijack open in a new window type events (middle-click, ctrl-click) and open them in a new tab instead, in order to preserve this relationship.

Additionally, 1.5.4 added persistence of window location & zoom levels - which works when a window contains a session for a particular profile, but might be a great deal more challenging when there could be multiple windows open for a profile - typical browser behaviour would zoom all tabs belonging to the same domain, but I don't quite like this anyway, because different windows could be on different displays, and legitimately need independent zoom levels.

jnawk commented 2 years ago

With the recent upgrade to electron 19 and tab reimplementation, this could be revisited. The multiple zoom levels thing remains a consideration.