search

jnbt / candy_check

Check and verify in-app receipts
MIT License
125 stars 70 forks source link

Expire checks for ReceiptCollection don't work in the iTunes sandbox #13

Closed the-mace closed 7 years ago

the-mace commented 7 years ago

When using the Sandbox the expiration checks are incorrect for the test subscriptions as subscription periods are much shorter.

expired? and overdue_days are day-based so they may work in production, but on the sandbox things expire much faster (minutes) so the check for expires would be better as something like this:

r.expires_date < Time.now.utc

Which would work both in production and the sandbox. The overdue_days isn't really a valid test for the sandbox. Also expired? depends on overdue_days.

The workaround for now is to not use expired? or overdue_days.

jnbt commented 7 years ago

@the-mace I get the point of the "faster" time in Apple's sandbox store. I tend to simply use the r.expires_date < Time.now.utc solution. Sadly I'm not able to perform manual tests for subscription. Would you or @klaseskilson be able to test the change?

the-mace commented 7 years ago

If you have a change I should be able to test it sometime. I'm using that r.expires_date < Time.now.utc for my expired check in production now.

jnbt commented 7 years ago

@the-mace I think I've fixed this issue. Could you be so kind and check the current master branch?

gem 'candy_check', git: 'https://github.com/jnbt/candy_check.git', ref: '1dee844'
the-mace commented 7 years ago

I tested this and it's working as expected. I'm now using the expired? test and it properly showed when it wasnt expired and then when it was expired.

jnbt commented 7 years ago

@the-mace Thanks! I've released version 0.1.1 to rubygems.org to address this issue.

the-mace commented 7 years ago

Wonderful, thanks for the support. Now if we can just get apple to let our app through...

jnbt commented 7 years ago

@the-mace I'm feeling with you. It's always the same: waiting, rejection, waiting, rejection, ... :-(