search

jnbt / candy_check

Check and verify in-app receipts
MIT License
125 stars 70 forks source link

Update upto Ruby 2.5.1 #27

Closed jnbt closed 6 years ago

jnbt commented 6 years ago

As this gem is currently stuck on Google::APIClient with version 0.8.6 we need to manually set the User-Agent header as Google::APIClient::ENV::OS_VERSION includes a invalid newline character.

This change mimics the old user agent so an update should be safe.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.4%) to 99.93% when pulling 04232b9cee38e7cb814e0cf88fdf8e6bb3270c86 on update-ruby into a61a68935c9aef8c0ac72e47b7b56c2451fb206f on master.

jnbt commented 6 years ago

Tests are OK for all Ruby versions. Only rubocop is crashing / failing for older Ruby versions.

jnbt commented 6 years ago

@sajmoon Can you try the version from this branch?

gem "candy_check", git: "git@github.com:jnbt/candy_check.git", branch: "update-ruby"
sajmoon commented 6 years ago

@jnbt, as I said in the issue, we have verified this fix for our use case and system. We upgraded to 2.4.4, not 2.5.1 though.

I see there are some problems in travis. When can we expect a release of this?

cheerfulstoic commented 6 years ago

We also ran into this going from Ruby 2.3.6 to 2.3.7. We're going to try out the fix to see if it helps (though it looks like the exact same issue, so I imagine it will)

jnbt commented 6 years ago

@cheerfulstoic Have you tried this branch? Any feedback is welcome before releasing this patch.

sajmoon commented 6 years ago

We have migrated to 2.5.1 without any visible problems. 👍

cheerfulstoic commented 6 years ago

We were able to upgrade to 2.3.7 with this patch without problems.

Thanks!

jnbt commented 6 years ago

Released as 0.1.2