jnbt / candy_check

Check and verify in-app receipts
MIT License
125 stars 71 forks source link

Add server ACK for consumable #50

Closed gerard-morera closed 4 years ago

gerard-morera commented 4 years ago

:pushpin: References

:dart: What is the goal?

Perform server purchases acknowledgement.

Purchases ACK is used to confirm to google play that the purchase flow happened as expected. If the ACK does not happen the purchase is refunded within 4 minutes.

If the ACK is done from the client-side and the validation to the server fails it will make users that have paid not having it's correspondent capabilities active. This candy_check new feature will let acknowledge the purchase after capabilities grant.

:memo: How is it being implemented?

Following Candy Check patterns and calling to Google API ACK service.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 98.615% when pulling 925e3985d5cf9ad4901a4fbdc85d79b56c5a0e08 on Badiapp:feature/add-server-ack-for-consumable into aa190df4ea43ecae61521f129cb4825ad54d2397 on jnbt:master.

jnbt commented 4 years ago

@gerard-morera Looks promising. Can you please also extend the README to describe this feature?

@christophweegen Can you please have a general review of this PR?

gerard-morera commented 4 years ago

@christophweegen and @jnbt thanks for your reviews. Renamed the typo and added the Readme.

FYI; this code has already been working one week in production in my company.

jnbt commented 4 years ago

@christophweegen Please have a second look. If you're fine with it. Please merge and release