Resolve test warnings - Githubissues

jnbt / candy_check

Check and verify in-app receipts

MIT License

125 stars 71 forks source link

Resolve test warnings #60

Closed tomorrowkey closed 3 years ago

tomorrowkey commented 3 years ago

There are too many warnings like following when running test. It is so noisy.

DEPRECATED: global use of must_be from spec/cli/commands/version_spec.rb:9. Use _(obj).must_be instead. This will fail in Minitest 6.

In this PR, resolve the similar warnings.

coveralls commented 3 years ago

Coverage decreased (-0.002%) to 98.638% when pulling cb407ac84525afe261db4ec8cea2d3a1401d7647 on tomorrowkey:resolve-test-warnings into ffc2415a6b236ccf3061ca35e47a0f27517f5152 on jnbt:master.

tomorrowkey commented 3 years ago

@jnbt What should I do? Improve or keep coverage percentage?

jnbt commented 3 years ago

@tomorrowkey LGTM

Thanks for this effort ✨ - I image it was quite some work