Closed tomorrowkey closed 3 years ago
@tomorrowkey There is already another PR #59 which removes the explicit version dependency completely which I don't really like.
I have at least one project stuck at thor < 1.0, but your changes seems to be fully backwards compatible.
So maybe we could use a slightly more relaxes version requirement, e.g. < 2.0
?
So maybe we could use a slightly more relaxes version requirement, e.g.
< 2.0
?
OK. It is better for us. I'll change the version specification right away.
I changed version specification by git amend.
And added a test for .exit_on_failure?
to keep testing coverage at 196073e
@jnbt Please review again
@tomorrowkey Thanks. Released as Version 0.4.0
Our project need thor to be version 1 or later to install by other dependencies. This PR will be update the gem.
Update gem
Thor shows warning when command line exit with error. Implement class method to resolve.
@jnbt Please look this 😉