search

jnbt / candy_check

Check and verify in-app receipts
MIT License
125 stars 71 forks source link

Update thor #62

Closed tomorrowkey closed 3 years ago

tomorrowkey commented 3 years ago

Our project need thor to be version 1 or later to install by other dependencies. This PR will be update the gem.

Update gem

Thor shows warning when command line exit with error. Implement class method to resolve.

$ ./bin/candy_check foo
Could not find command "foo".
Deprecation warning: Thor exit with status 0 on errors. To keep this behavior, you must define `exit_on_failure?` in `CandyCheck::CLI::App`
You can silence deprecations warning by setting the environment variable THOR_SILENCE_DEPRECATION.

@jnbt Please look this 😉

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.004%) to 98.643% when pulling 196073e64e0ca6b4355ca57cbbde24570c2bf0b8 on tomorrowkey:update-thor into 141a90c05ba33fbce2891efb17438a29863d46f1 on jnbt:master.

jnbt commented 3 years ago

@tomorrowkey There is already another PR #59 which removes the explicit version dependency completely which I don't really like.

I have at least one project stuck at thor < 1.0, but your changes seems to be fully backwards compatible.

So maybe we could use a slightly more relaxes version requirement, e.g. < 2.0?

tomorrowkey commented 3 years ago

So maybe we could use a slightly more relaxes version requirement, e.g. < 2.0?

OK. It is better for us. I'll change the version specification right away.

tomorrowkey commented 3 years ago

I changed version specification by git amend. And added a test for .exit_on_failure? to keep testing coverage at 196073e

tomorrowkey commented 3 years ago

@jnbt Please review again

jnbt commented 3 years ago

@tomorrowkey Thanks. Released as Version 0.4.0