Closed dsantosmerino closed 2 years ago
@dsantosmerino Thanks for this contribution. Really appreciated.
@christophweegen Please have a look here. It fails on Ruby 2.4, but I think this acceptable as < 2.6 Ruby isn't officially supported anyways.
@jnbt @christophweegen Can we drop Ruby 2.4 and 2.5 support?
@dsantosmerino For me it would be OK to drop Ruby 2.4 support (but a breaking change). We would need to keep 2.5 from our use cases because we rely on JRuby which is still on Ruby 2.5.x level.
JRuby 9.2.x is compatible with Ruby 2.5.x and stays in sync with C Ruby.
We also should extend the CI system to test for 2.7.
@jnbt It should be ready now. Let me know if you need anything else from my side.
Hey @jnbt, do I need to change something else?
lets hope this gets merged.
I tried testing this PR directly, I'm still getting this error:
Bundler could not find compatible versions for gem "google-apis-androidpublisher_v3":
In snapshot (Gemfile.lock):
google-apis-androidpublisher_v3 (>= 0.6.0)
In Gemfile:
google-apis-androidpublisher_v3 (~> 0.6.0)
candy_check was resolved to 0.4.0, which depends on
google-apis-androidpublisher_v3 (~> 0.2.0)
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
Hey @christopheragnus, I just tested it out in a fresh Ruby project adding the dependency from the PR-related branch with Ruby 3.0.1, and it works fine.
My related test:
# Gemfile
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
ruby '3.0.1'
gem 'candy_check', git: 'https://github.com/Badiapp/candy_check',
branch: 'upgrade/google-api-client'
Hey @dsantosmerino - I think this is caused because it's using an older version of google-apis-androidpublisher_v3
. I think you need to update the dependecies to the latest one?
@christopheragnus @jnbt We're already using this on our production services 😸
@dsantosmerino @jnbt hey there! Are you going to merge this anytime soon?
@dsantosmerino thank you for this pull request! @jnbt can you please merge it? Looks like all the support of JRuby and Ruby 2.5+ is in place.
@christophweegen thank you!
@skliarov you're welcome. Thanks to you and all the other contributors.
Sorry that progress in this project was a bit delayed in the last months.
Will make sure to close most of the open issues to the end of the year.
this is still an issue in the latest 4.0 gem?
What's the fix?
When is this fix going to be released in the gem bundle?
As explained in their docs Google changed their approach managing their services gems and the global
google-api-client
is deprecated.Here we only need access to the Android Publisher and the Auth ones, replacing the global one.
This change enables also the support for Ruby 3.0, so it fixes #64.