search

jncc / web-mapper-core

Common web-mapper components for the JNCC websites
6 stars 1 forks source link

Insertion into Umbraco as Iframe #13

Closed andyb-esdm closed 5 years ago

SimonAnnetts commented 5 years ago

Hi @ulric-wilson Here is the url that you can put in the iframe within your CMS: http://jnccdev-map.esdm.co.uk/ or https://jnccdev-map.esdm.co.uk/

The map is talking to a skeleton web-api at http://jnccdev-api.esdm.co.uk/ and is requesting the two items in the Map Instances box on the map. We've set the CORs policy on the web-api to allow access from any domain. Please let me know (or send me a link to the page on your CMS) how the test goes :)

thanks

ulric-wilson commented 5 years ago

Simon Mapper appears in basic fixed size iframe on page http://jncc.defra.gov.uk/default.aspx?page=7718 It seems to be rendering fine but can you test it has the functionality you expect?

NB - this iframe is not in Umbraco but is embedded within an Alterian page (our old CMS), so strictly not a test of Umbraco. That said it is on the final domain that the mapper will sit on.

Ulric

andyb-esdm commented 5 years ago

HI @LynnHeeley could you arrange to get the JavaScript to resize the iframe on window resize so we can check that the map resizes correctly too? Let me know if you need more details.

ulric-wilson commented 5 years ago

Added CSS to resize iframe as JS had issues I couldn’t quickly fix

Ulric Wilson Co-Team Leader, Digital and Data Solutions Tel: 01733 866853, Mob: 07741 901730

From: Andy Brewer notifications@github.com Sent: 12 February 2019 10:22 To: jncc/web-mapper-core web-mapper-core@noreply.github.com Cc: Ulric Wilson Ulric.Wilson@jncc.gov.uk; Mention mention@noreply.github.com Subject: Re: [jncc/web-mapper-core] Insertion into Umbraco as Iframe (#13)

HI @LynnHeeleyhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLynnHeeley&data=02%7C01%7CUlric.Wilson%40jncc.gov.uk%7C53f5655743344179dfc108d690d3f987%7C444ee4e8b2fd491d8c318b0508370a6b%7C0%7C0%7C636855637434256271&sdata=z3mrFSxROjdXmfD8aOfACGopYikAO197xut02CIXYJI%3D&reserved=0 could you arrange to get the JavaScript to resize the iframe on window resize so we can check that the map resizes correctly too? Let me know if you need more details.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjncc%2Fweb-mapper-core%2Fissues%2F13%23issuecomment-462702640&data=02%7C01%7CUlric.Wilson%40jncc.gov.uk%7C53f5655743344179dfc108d690d3f987%7C444ee4e8b2fd491d8c318b0508370a6b%7C0%7C0%7C636855637434266277&sdata=0dZOHLCCe3avw%2F1mRV26%2BJ530g0sNLh%2Bou3fweccVQ0%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACuJ78n7w8MPMn7MQU0pqq9CMRlfMsGBks5vMpXbgaJpZM4aE5ws&data=02%7C01%7CUlric.Wilson%40jncc.gov.uk%7C53f5655743344179dfc108d690d3f987%7C444ee4e8b2fd491d8c318b0508370a6b%7C0%7C0%7C636855637434266277&sdata=RsY76F6o0MM2OvPumN6dv80FQHYL%2B8765mCwPalA17Q%3D&reserved=0.

For information on how we handle personal data please see our Privacy Notice at http://jncc.defra.gov.uk/privacypolicy

This email and any attachments, is intended for the named recipient(s) only. If you are not the named recipient then any copying, distribution, storage or other use of the information contained in them is strictly prohibited. In this case, please inform the sender straight away then destroy the email and any linked files.

JNCC may have to make this message, and any reply to it, public if asked to under the Freedom of Information Act, data protection legislation or for litigation. If you have a Freedom of Information/Environmental Information request please refer to our website page.

This message has been checked for all known viruses by JNCC through the MessageLabs Virus Control Centre however we can accept no responsibility once it has left our systems. The recipient should check any attachment before opening it.

JNCC Support Co. registered in England and Wales, Company No. 05380206. Registered Office: Monkstone House, City Road, Peterborough, Cambridgeshire PE1 1JY. http://jncc.defra.gov.uk/

andyb-esdm commented 5 years ago

Hi @ulric-wilson I had read (or heard) that you couldn't use CSS to resize an iframe, which is why I suggested some js/jQuery but obviously you can - good to know this. Thanks for doing it so quickly. It works too!

ulric-wilson commented 5 years ago

From here https://benmarshall.me/responsive-iframes/

Ulric Wilson Co-Team Leader, Digital and Data Solutions Tel: 01733 866853, Mob: 07741 901730

From: Andy Brewer notifications@github.com Sent: 12 February 2019 13:02 To: jncc/web-mapper-core web-mapper-core@noreply.github.com Cc: Ulric Wilson Ulric.Wilson@jncc.gov.uk; Mention mention@noreply.github.com Subject: Re: [jncc/web-mapper-core] Insertion into Umbraco as Iframe (#13)

Hi @ulric-wilsonhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fulric-wilson&data=02%7C01%7CUlric.Wilson%40jncc.gov.uk%7Cccc33234094a4f75d97508d690ea5302%7C444ee4e8b2fd491d8c318b0508370a6b%7C0%7C0%7C636855733428474718&sdata=J6UtLo8AMMWRLfl1TTKDJyzhFIcZe%2BRKR1isS%2FKkSZk%3D&reserved=0 I had read (or heard) that you couldn't use CSS to resize an iframe, which is why I suggested some js/jQuery but obviously you can - good to know this. Thanks for doing it so quickly. It works too!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjncc%2Fweb-mapper-core%2Fissues%2F13%23issuecomment-462750503&data=02%7C01%7CUlric.Wilson%40jncc.gov.uk%7Cccc33234094a4f75d97508d690ea5302%7C444ee4e8b2fd491d8c318b0508370a6b%7C0%7C0%7C636855733428484727&sdata=o2joTJHJoXq8BEGV00iUW7%2BHFVnZV18f%2BwQrC0EYPw4%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACuJ747BleKP8-VuJMsaolVwyxPIu2uvks5vMrtXgaJpZM4aE5ws&data=02%7C01%7CUlric.Wilson%40jncc.gov.uk%7Cccc33234094a4f75d97508d690ea5302%7C444ee4e8b2fd491d8c318b0508370a6b%7C0%7C0%7C636855733428484727&sdata=bfbH9Mt06fnQKOFN10FGURAuWktpEjaRvrg0FOVYtnc%3D&reserved=0.

For information on how we handle personal data please see our Privacy Notice at http://jncc.defra.gov.uk/privacypolicy

This email and any attachments, is intended for the named recipient(s) only. If you are not the named recipient then any copying, distribution, storage or other use of the information contained in them is strictly prohibited. In this case, please inform the sender straight away then destroy the email and any linked files.

JNCC may have to make this message, and any reply to it, public if asked to under the Freedom of Information Act, data protection legislation or for litigation. If you have a Freedom of Information/Environmental Information request please refer to our website page.

This message has been checked for all known viruses by JNCC through the MessageLabs Virus Control Centre however we can accept no responsibility once it has left our systems. The recipient should check any attachment before opening it.

JNCC Support Co. registered in England and Wales, Company No. 05380206. Registered Office: Monkstone House, City Road, Peterborough, Cambridgeshire PE1 1JY. http://jncc.defra.gov.uk/

SimonAnnetts commented 5 years ago

closing this as work completed. Please open a new issue if bugs found.