search

jncornett / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

HRESULT tests fail on non-english windows #34

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
On Fri, Sep 12, 2008 at 3:12 PM, balazs.dan <Balazs.Dan@gmail.com> wrote:
>
> Hello guys,
>
> I've run gtest_unittest on a Hungarian Windows and these tests failed:
> EXPECT_HRESULT_SUCCEEDED
> ASSERT_HRESULT_SUCCEEDED
> EXPECT_HRESULT_FAILED
> ASSERT_HRESULT_FAILED
> The reason is gtest_unittest tests error messages also and these
> messages are localized on windows.
>
> I'm not sure it is a real issue or not, but better to know this
> thing..

Thanks for the report!  I believe this only indicates that the tests
aren't portable, and the assertions themselves should be sound.  The
tests for the error messages aren't really critical,and it would be
too much hassle to localize them, so I think we'll just disable these
tests.

Original issue reported on code.google.com by shiq...@gmail.com on 12 Sep 2008 at 10:30

GoogleCodeExporter commented 9 years ago 
Fixed in trunk.  Will be in 1.1.0.

Original comment by shiq...@gmail.com on 17 Sep 2008 at 6:54