jncraton / course-search

1 stars 0 forks source link

Filter form #132

Closed jepoorbaugh closed 1 month ago

jepoorbaugh commented 1 month ago

Moves filter inputs to a new <form> section, improving accessibility and readability. It also provides some minor formatting with a stylesheet called styles.css.

People working on implementing filter functionality should still implement their own filters and merge them with either this branch or main once this branch is merged.

Closes #129

jepoorbaugh commented 1 month ago

@dtlemon got it, the filter button is now gone.

Peyton3995 commented 1 month ago

I'll approve of this because I think it is a great start for other people to work on, but I have a few questions such as what I should do with my own filter option. What I am going to do is in my PR, add a time row and move the time option above it, similar to how Sort by Credit is. image

I have been informed why it is made that way, and while it makes since to have a distinction between filters and sorts, we need to make that more visually distinct down the line once more functionality has been achieved. As of now though, this is perfectly fine and a good base for others to work off of.