Colour choice for .kwd has a very low contrast ratio on dark themes

jneale / Xplore

Xplore: Developer Toolkit for ServiceNow

MIT License

193 stars 146 forks source link

Colour choice for .kwd has a very low contrast ratio on dark themes #44

Closed n21lv closed 3 years ago

n21lv commented 3 years ago

It's almost impossible to see keywords like true or false in the Output tab. In code inspector the colour choice shows a contrast ratio of 1.4. WCAG Level AAA requires a contrast ratio of at least 7:1 for normal text and 4.5:1 for large text. Please make it at least WCAG Level AA-compliant.

Further reading: https://webaim.org/resources/contrastchecker/#:~:text=WCAG%20Level%20AAA%20requires%20a,(typically%2024px)%20or%20larger.

jneale commented 3 years ago

Hi, please can you share which theme is giving you issues? A screenshot would also be helpful.

Themes are currently in beta and as such will have some issues as they are intended only for CodeMirror and so porting to the wider page is quite a bit of effort.

n21lv commented 3 years ago

Hello! I actually experience it in every dark theme. Here I have 3024-night enabled

I think if you change it to something like #01a0e4, it will be much easier on the eye.

jneale commented 3 years ago

Fixed in 4.9.