search

jneen / pjs

Classes for javascript that don't suck.
MIT License
195 stars 29 forks source link

Minor JSHint Edits #17

Closed danro closed 11 years ago

danro commented 11 years ago

JSHint was complaining about a function invocation, so this edit fixes that and slightly improves clarity in the process. (sorry for a couple extra bytes tho)

jneen commented 11 years ago

Ehh, I'll take the fewer bytes and let JSHint complain. We're all consenting adults here. Also you seem to have bumped the version...? But I'll fix that semicolon issue.

danro commented 11 years ago

Bahh .. micro-optimization over readability. With gzip, that's like -0 bytes.

Sorry bout the version bump. I thought that was helpful for npm..

jneen commented 11 years ago

Haha, well you've got me there. This project actually started as a "limbo" experiment, which was later found to be actually useful :) (you'll notice that in early commits, P was called Limbo). I guess I've held on to that attitude a bit?

And it's not that bad, really - the initial ( is an indicator that it's going to be called.

I usually bump the version in a nice tagged commit with a message containing the new version number, and an update to the changelog, so I prefer to do those myself.

Thanks for the pull request, though - it is nice to know people care enough to help out :)