search

jneilliii / OctoPrint-BackupScheduler

11 stars 3 forks source link

[BUG]: whitespace in backup filenames #23

Open togeis opened 2 years ago

togeis commented 2 years ago

Describe the bug Space in backup filenames: -rw-r--r-- 1 admin administrators 25M 2022-01-13 01:26 OctoPrint-Ender-5-backup-20220113-012544.zip <- (manually) -rw-r--r-- 1 admin administrators 25M 2022-01-13 01:41 OctoPrint Ender 5-daily-20220113-013720.zip. <- (scheduled)

Maybe it is a feature request, but i have a backup-created event and in {path} is the backupfile name. And with whitespaces, the command does not find the file. I have escaped the var and it is running, but whitespaces in filenames under unix/linux is not so optimal.

Expected behavior no whitespace in unix filenames for the zip files like the files being named, when triggering the backup over the OctoPI GUI manually

Debug Log no logs

Screenshots

image

Firmware and Version Using : OctoPrint 1.7.2 Python 3.7.3 OctoPi 0.17.0

Thx&Regards togeis

jneilliii commented 2 years ago

I don't necessarily consider this a bug, as the filename is technically still valid. I have marked this as a feature request and will need to adjust the line here to account for spaces in the printer's appearance name.