jneilliii / OctoPrint-BedLevelVisualizer

MIT License
372 stars 82 forks source link

[BUG]: Decending X-Axis changes axis titles and data, but not tooltips/hover #490

Open jberry opened 2 years ago

jberry commented 2 years ago

Describe the bug When you select "Descending x-axis", the data and axis titles rotate, but when you hover-over the data, it's showing the non-flipped-data for rotation

Expected behavior I expect the tooltips/hover to be correct

Screenshots xaxis1 xaxis2

Firmware and Version Bed Visualizer Settings version 1.1.0

jneilliii commented 2 years ago

Thank you for your report. When I get some time I'll investigate this further. I've never really been happy with how this table works (was contributed by someone else).

jberry commented 2 years ago

Yeah, I'm not overly fond of it, especially when you start rotating the graphic and the table is static, and you start adjusting things wrong (totally user fault: mine). But it'd be nice if the graphic at least loaded in the same orientation as the table's data layout (i.e. front edge in my graphic should load as 315:340, not 0:0, when the table is flipped via checkboxes/etc.)

I haven't checked out the project yet to poke around myself, but if I get time I'll see if I can as well

jneilliii commented 2 years ago

rather than actually fixing this I'm just going to take the hover tooltip out completely. It just doesn't seem to be beneficial and taking it out should actually improve processing time.

jberry commented 2 years ago

This did not resolve the data issue of the right chart, the data is still flipped. As you can see in my screenshot below, mousing over the blue 50 shows the data for the red 3: image And here's the opposite, mousing over the red 3 shows the data for the blue 50: image

jneilliii commented 2 years ago

Sorry I wasn't paying attention. I thought the issue that the arrow on the mouse pop-over was incorrect, not the actual calculated turns.