jneilliii / OctoPrint-BedLevelVisualizer

MIT License
372 stars 82 forks source link

[FR]: Change sizes of axis to allow setting up to actual bedsize? #625

Closed Dazzlermc closed 1 year ago

Dazzlermc commented 1 year ago

Is your feature request related to a problem? Please describe. When performing a bed level the graph shows axis bigger than my actual printer bed , which causes the reading to be incorrect. In this example the bed is 300 x 300 my bed is 220 x 220 . I find the graph more useful and easier to view

Describe the solution you'd like Allow a bed size to be set for the actual size of the bed measurements..

Describe alternatives you've considered Tried changing the bed size in Octoprint , but no effect.

Additional context

bedvisualizer

jneilliii commented 1 year ago

The plugin pulls the bed size directly from the current printer profile dimensions in OctoPrint's settings. Once that is correct the next collection will update.

Dazzlermc commented 1 year ago

It hasn’t pulled them down from my printer profile. Which is set to 220 x 235 x 250

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: 22 July 2023 16:08 To: @.> Cc: @.>; @.> Subject: Re: [jneilliii/OctoPrint-BedLevelVisualizer] [FR]: Change sizes of axis to allow setting up to actual bedsize? (Issue #625)

The plugin pulls the bed size directly from the current printer profile dimensions in OctoPrint's settings. Once that is correct the next collection will update.

— Reply to this email directly, view it on GitHubhttps://github.com/jneilliii/OctoPrint-BedLevelVisualizer/issues/625#issuecomment-1646603591, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A274HJ7OA6RZCDVR7YDGVS3XRPUGZANCNFSM6AAAAAA2T326MQ. You are receiving this because you authored the thread.Message ID: @.***>

jneilliii commented 1 year ago

please enable debut logging in the plugin's settings, restart OctoPrint and try the update mesh button again. share your plugin_deblevelvisualizer_debug.log file from OctoPrint's logging section. You can drag it directly into a comment here in GitHub, you can't email it in a reply...

Dazzlermc commented 1 year ago

plugin_bedlevelvisualizer_debug (1).log

jneilliii commented 1 year ago

Thanks, can you share a screenshot of your active printer profile settings? The plugin is seeing 300x255x250 for some reason.

{'type': 'rectangular', 'x_min': 0, 'x_max': 300.0, 'y_min': 20, 'y_max': 255.0, 'z_min': 0, 'z_max': 250.0}

Dazzlermc commented 1 year ago

Printer settings

jneilliii commented 1 year ago

I'm very confused about this. could you do me one more favor, enable serial logging in OctoPrint's Serial Connection settings, do an update mesh process and then disable it back and share serial.log from OctoPrint's logging section? Also, to verify the printer profile above is the only printer profile you have or is the one that has the star next to it?

image

Dazzlermc commented 1 year ago

That's not my printer profiles. ?

Dazzlermc commented 1 year ago

printer profiles

jneilliii commented 1 year ago

Yeah, that was a screenshot from my OctoPrint. Just to be 100% certain, what is the profile selected in the connection tab?

image

Dazzlermc commented 1 year ago

Ender3 is selected. I have tried the other profiles and there is no difference. plugin_bedlevelvisualizer_debug (1).log

jneilliii commented 1 year ago

The only other reasons the size wouldn't match the current printer profile would be if it's being extracted from the mesh report from your printer, or you have some offsets configured in the plugin's settings. Do you have any offsets configured in the plugin's settings? If not, then I will definitely need the serial.log during the update mesh process.

Dazzlermc commented 1 year ago

serial (3).log

jneilliii commented 1 year ago

Yeah, so it's definitely not interpreting the dimensions from the collection process. And if nothing is entered here in these settings it should be coming from the printer profile.

image

Does it do the same thing if you turn off the reference plane option in visualization settings?

Dazzlermc commented 1 year ago

offsets were not 0. I've set them at 0 and it is now reporting the size of the bed as correct. Graph still awful though, but I get a fresh start. Thank you for your help.

jneilliii commented 1 year ago

I think there was a bug in pulling the bed dimensions from the profile data anyway. I've refactored the reference plane code to use the min/max x/y values being passed by the collection process so they will now match up even with offsets applied. Will be available as version 1.1.2rc6 shortly.