jneilliii / OctoPrint-BedReady

11 stars 3 forks source link

OctoPrint 1.9.0 Compatibility #15

Open jneilliii opened 1 year ago

jneilliii commented 1 year ago
extracted/bedready/OctoPrint-BedReady-master/octoprint_bedready/templates/bedready_settings.jinja2:<div class="well alert-danger" data-bind="visible: !snapshot_valid()"><p>Invalid Snapshot URL configured in <a href="javascript:void(0)" data-bind="click: function(){ settingsViewModel.show('#settings_webcam'); }">Webcam & Timelapse</a> settings. That setting must be configured with a full url for this plugin (as well as timelapse) to function properly.</p></div>
extracted/bedready/OctoPrint-BedReady-master/octoprint_bedready/static/js/bedready.js:            return self.settingsViewModel.webcam_snapshotUrl().length > 0 && self.settingsViewModel.webcam_snapshotUrl().startsWith('http');
arrdem commented 1 year ago

+1, on 1.9.0 if the bed is unready prints fail to pause despite the image recognition machinery detecting that the bed is unready.

jneilliii commented 1 year ago

I haven't had time to work on my plugins because of work. If you don't mind, could you go to OctoPrint's logging section and enable debug logging for plugin.bedready at the bottom of the page and try again? Then share your octoprint.log after the failed detection.

arrdem commented 1 year ago

Will see if I can dig up some useful debug information.

I took a quick look last night, didn't find anything immediately at fault in the plugin and just made manually invoking the plugin a prereq for pushing a job to a printer :/ https://git.arrdem.com/arrdem/source/commit/730a6a3950b751cb9177c6cabce0e5541de0fa91

Right off what I did see in the logs is that the plugin is firing, does detect that the bed is unready and does attempt to pause but the printer doesn't accept the job state transition. May be a bug/change on the OctoPrint side.

jneilliii commented 1 year ago

I don't think anything changed from the perspective of job control, but if I do get a chance to investigate/test further I will.