search

jneilliii / OctoPrint-BedReady

11 stars 3 forks source link

Add Region of Interest options #26

Open RoboMagus opened 1 week ago

RoboMagus commented 1 week ago

Work in progress solution for #6.

ROI settings canvas based on MarkSlat/OctoPrint-Hologram.

jneilliii commented 1 week ago

Wonder if you saw the making branch? I want every fully happy with the implementation and there were weird things with resizing on the canvas that caused things to not align, so if your methods work another I'm all for it.

RoboMagus commented 3 days ago

Prior to drafting this PR I had not noticed the other branch, my apologies (I only found no PR open on the issue some time ago) . I had some time last weekend to tinker around with an implementation for this issue so I went with it.

Looking at that the masking branch it seems development stalled some time ago, is that related to the canvas resizing issue you mention? What exactly is the problem you're running into? I'll try to test that use-case next time I've got some time available to work on this to see if its handled properly.

jneilliii commented 3 days ago

Yeah, it stalled because of time and that resizing issue. I'm more than happy to review and accept a working solution though.