search

jneilliii / OctoPrint-ConsolidatedTabs

22 stars 1 forks source link

Control tab with fullscreen webcam plugin installed does not work when is used in a consolidated tabs plugin #21

Closed LarryVand closed 4 years ago

LarryVand commented 4 years ago

Control tab with fullscreen webcam plugin installed does not work when is used in a consolidated tabs plugin.

To see the issue, have control tab alone (NOT in a consolidated tabs window), and if you double click the webcam it goes to full screen. Then put the control tab in a consolidated tabs window and if you double click the webcam nothing happens. And the webcam fullscreen does not work in a consolidated tab, even if the control tab is the ONLY ONE in the consolidated tabs window.

I'm posting this to both places just so the two authors of the 2 plugins are aware of the incompatibility.

jneilliii commented 4 years ago

Establishing link to other plugin https://github.com/BillyBlaze/OctoPrint-FullScreen/issues/29.

So I think the issue here is related to the jQuery UI Selectable/Draggable/Resizable modules that I'm using in this plugin as it will prevent click actions from elements within the panels. I think I can fix this but need to go through the process of installing that plugin, coding, testing.

jneilliii commented 4 years ago

So I just installed the fullscreen plugin and it's working for me without issue. Double-clicking the webcam image opens up the fullscreen view. What browser are you using?

LarryVand commented 4 years ago

I'm using chrome V 84.0.4147.135. Maybe I should try uninstalling the fullscreen plugin and reinstalling and see if that makes a difference. Hold on... Nope. It still does not work when is on a consolidated Tabs window. But it works in its own tab. Here is a pic how I have it setup when it does not work. 2Capture

jneilliii commented 4 years ago

I see one other difference that I don't have. You have the ArduCam Focus plugin installed and I do not.

https://drive.google.com/file/d/1Vzc2xj53uzQrkM0ZVvwO_UVRcufP9XzH/view?usp=sharing

If you wanted you could try the version in my current working branch where I added the img tag to be non-blocking, but I cannot reproduce this with just fullscreen and consolidated tabs alone. If you want to try the other version copy/paste the URL below in Plugin Manager > Get More > ...from URL and click install.

https://github.com/jneilliii/OctoPrint-ConsolidatedTabs/archive/0.1.1.zip
LarryVand commented 4 years ago

Let me try and remove the ArduCam focus plugin and see if that helps...Nope. Removing the ArduCam focus and still fullscreen has the issue in Consolidated tabs.

I'll try the 0.1.1 version and let you know... SUCCESS!!!! The non-blocking img tag you added did the trick. Awesome job!

jneilliii commented 4 years ago

That's strange that it was working for me, but glad that sorted it out for you.

LarryVand commented 4 years ago

Maybe you already were running a version that had the non-blocking img tag already? Who knows. I used to be in the IT field 20 years ago and the dependencies were so many in windows and networking to try and fix bugs, that it drove me crazy and made me switch fields because of it.