search

jneilliii / OctoPrint-ConsolidatedTabs

22 stars 1 forks source link

[BUG]: Custom Tab-icons with Themeify #35

Open ShagoY opened 3 years ago

ShagoY commented 3 years ago

Hi Jim,

I use the "Custom Tab-icons" feature of the "Themeify" plugin. When the tabs are linked to an icon, the tabs in the configuration page of your plugin do not display the title. So I have an empty list with a bunch of buttons. Well since I know the order, I could configure it but it's not practical.

With "Custom Tab-icons":

<li id="timelapse_link">
   <a href="#timelapse" data-toggle="tab"><i class="fa fa-film"></i></a>
</li>

Without "Custom Tab-icons": 

<li id="tab_plugin_SpoolManager_link">
   <a href="#tab_plugin_SpoolManager" data-toggle="tab">Spools</a>
</li>

"Custom Tab-icons" adds the title of the tab with CSS and removes the text.

So it might be interesting to display the ID or HREF of the tab in case there is no text.

What do you think about it?