search

jneilliii / OctoPrint-CustomBackground

10 stars 3 forks source link

Background image overfills the box #10

Closed iamjameshannam closed 7 years ago

iamjameshannam commented 7 years ago

The first version had great scaling for the image, the uploaded image seemed to resize to fit the window. This version, the image is HUGE, off the page....

jneilliii commented 7 years ago

The first version actually had no scaling at all set. The latest update changed the fill method to better size the image. Maybe it's working for me because I'm using the cyborg theme. Are you using a url, or file upload?

On Sep 1, 2017 10:09 AM, "James Hannam" notifications@github.com wrote:

The first version had great scaling for the image, the uploaded image seemed to resize to fit the window. This version, the image is HUGE, off the page....

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jneilliii/OctoPrint-CustomBackground/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAZr-yjkyvitf1QM5qogAGtbkz0uMV1ks5seA_8gaJpZM4PKMyx .

jneilliii commented 7 years ago

Also, what browser are you using?

jneilliii commented 7 years ago

I've updated to version 0.5.0 that allows you to control the background-size property. If you set it to auto it will be back to the way it was prior to version 0.4.0.

iamjameshannam commented 7 years ago

Hi!

Im using the file upload, the new version youve done works perfectly!!!

Awsome job sir!!!

James

https://mailtrack.io/ Sent with Mailtrack https://mailtrack.io/install?source=signature&lang=en&referral=thelearnmaker@gmail.com&idSignature=22

On 1 September 2017 at 15:41, jneilliii notifications@github.com wrote:

The first version actually had no scaling at all set. The latest update changed the fill method to better size the image. Maybe it's working for me because I'm using the cyborg theme. Are you using a url, or file upload?

On Sep 1, 2017 10:09 AM, "James Hannam" notifications@github.com wrote:

The first version had great scaling for the image, the uploaded image seemed to resize to fit the window. This version, the image is HUGE, off the page....

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jneilliii/OctoPrint-CustomBackground/issues/10 <https://mailtrack.io/trace/link/0d3959be410bfdce225bd2f1289dde337026c582?url=https%3A%2F%2Fgithub.com%2Fjneilliii%2FOctoPrint-CustomBackground%2Fissues%2F10&userId=773403&signature=a1fc8f58987afaa4>, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAZr- yjkyvitf1QM5qogAGtbkz0uMV1ks5seA_8gaJpZM4PKMyx <https://mailtrack.io/trace/link/06501a0a0e73c42fcf6a1c8b7388952a2b246074?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFAZr-yjkyvitf1QM5qogAGtbkz0uMV1ks5seA_8gaJpZM4PKMyx&userId=773403&signature=b6f6006082bcf252

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://mailtrack.io/trace/link/f53f687aa14f9a5aedbb296102616a2d09eac8e3?url=https%3A%2F%2Fgithub.com%2Fjneilliii%2FOctoPrint-CustomBackground%2Fissues%2F10%23issuecomment-326598736&userId=773403&signature=8f17c964f1eb8612, or mute the thread https://mailtrack.io/trace/link/8da50a317591feabf0ffc40794eb0201033dfef9?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXZW9lvwPToLmWcztXQn5n1fvvaFNVr0ks5seBeXgaJpZM4PKMyx&userId=773403&signature=392c2c11b7fe45e4 .

jneilliii commented 7 years ago

cool, thanks for the feedback.