jneilliii / OctoPrint-DragonOrder

9 stars 1 forks source link

Sidebar ordering not working #6

Closed ygtc closed 5 years ago

ygtc commented 5 years ago

I can't order my siderbar :/ tabs are ok and navbar ok. I'm using your other plugins are consolidate temp control and taborder.

Is might be reason about sidebar can not order?

jneilliii commented 5 years ago

Which version did you install? The latest version introduced a filter that allows the dragging only on the header row of the sidebar panels so make sure you're grabbing a white space next to the title of the panel.

ygtc commented 5 years ago

sorry for late response but;

installed 0.1.2 version and also yes, i try to grab from only header row of sidebar items but not work :/ Did i something wrong ?

jneilliii commented 5 years ago

What other plugins do you have installed? I wonder if there may be a conflict with something else. It's working fine for me. One thing that may help, is minimizing all the sidebar panels so you aren't having to move them as much to get them where you want them.

jr-k commented 5 years ago

Same for me, can sort everything except sidebars

jneilliii commented 5 years ago

Same question, what other plugins do you have installed, specifically in the sidebar. Any errors in the browser's developer console or octoprint.log? What browser?

kabaur commented 5 years ago

Same for me, too. I checked with Firefox 64.0 and Chrome 71.0.3578.98. DragonOrder Plugin 0.1.2. Other Plugins are:

When I minimise the sidebar entries by clicking on the name I get an TypeError in the firefox console: TypeError: $(...).find(...).andSelf is not a function[Weitere Informationen] packed_plugins.js:5333:58 _mouseCapture http://192.168.X.XX/static/webassets/packed_plugins.js:5333:58 $.widget/</prototype[prop]</< (I put the X.XX there)

Same happens wenn I click on the empty space next to it. So I guess this could be the source of the error? Nothing in the octoprint log.

jneilliii commented 5 years ago

Strange. Did you disable both plugins at the same time? What is the code when you click on the url in the console like http://192.168.x.xx/static/webassets/packed_plugins.js:5333:58 above?

kabaur commented 5 years ago

Yes I disabled them both at the same time but only checked in Firefox. The code is: var validHandle = false; $(this.options.handle, currentItem).find("*").andSelf().each(function() { if(this == event.target) validHandle = true; }); Thats for the _mouseCapture line (5333:58 in packed_plugins.js).

The full error code is: TypeError: $(...).find(...).andSelf is not a function[Weitere Informationen] packed_plugins.js:5333:58 _mouseCapture http://192.168.X.XX/static/webassets/packed_plugins.js:5333:58 $.widget/</prototype[prop]</< http://192.168.X.XX/static/webassets/packed_plugins.js:4638:28 _mouseDown http://192.168.X.XX/static/webassets/packed_plugins.js:5134:44 $.widget/</prototype[prop]</< http://192.168.X.XX/static/webassets/packed_plugins.js:4638:28 _mouseInit/< http://192.168.X.XX/static/webassets/packed_plugins.js:5096:20 dispatch http://192.168.X.XX/static/webassets/packed_libs.js:5183:16 add/elemData.handle http://192.168.X.XX/static/webassets/packed_libs.js:4992:6

The add/elemData.handle link points to: if ( !( eventHandle = elemData.handle ) ) { eventHandle = elemData.handle = function( e ) { // Discard the second event of a jQuery.event.trigger() and // when an event is called after a page has unloaded return typeof jQuery !== "undefined" && jQuery.event.triggered !== e.type ? jQuery.event.dispatch.apply( elem, arguments ) : undefined; }; }

The jQuery.event.dispatch.apply( elem, arguments ) : undefined; line is the source of the error.

R0dri commented 5 years ago

Having the same trouble, any update?

I have disabled every plugin that had something to do with the sidebar and nothing. I kept getting the same errors posted above.. Then I went ahead and enable every plugin disabled and disabled dragon order and the error was gone. I believe we are spot on by saying the error is somewhat related to jQuery and mouse events.

jneilliii commented 5 years ago

Maybe this a language issue for some reason, not sure why. @R0dri, is yours also in German(?)? Maybe I have another plugin installed that is making it work as expected that you guys don't have, although I don't see why that would be the case. I'm in the process now of setting up my python3 dev environment to test my plugins, so I have a clean OctoPrint install and will test this out there to see.

jneilliii commented 5 years ago

So just installed in brand new environment and it is still working without issue for me, so at this point not really sure why this is happening.

R0dri commented 5 years ago

looks weird. No, I am in English. I'll try to disable every plugin/mod to sort out if it is a plugin or maybe a buggy installation that I have. I will also try a brand new environment, test it is working as you said, then proceed to install all my plugins in batches to see what is going on. Let you know in a couple of days what I can find.

JdeV987 commented 5 years ago

I have the same problem, can sort everything except sidebars, running OctoPrint: 1.3.10 and Dragon Order (0.1.3) Have these other plugins installed: Action Command Prompt Bed Leveling Wizard CuraEngine (<= 15.04) E-Stop Settings EEPROM Marlin Editor Plugin Fan Speed Control Heater Timeout Navbar Temperature Plugin System Command Editor Yamlpatcher

jneilliii commented 5 years ago

Have you guys tried minimizing the panels first to make it easier to move? The sidebar panels can only be moved up and down in the sidebar. Are any of your instances publically available and you're willing to share a login with me to see it for myself? I've installed the plugin on 3 different pi installs and 2 windows installed and it's worked on every one of them.

JdeV987 commented 5 years ago

Yes, panels are minimized. Still can't move the menu items. I use Win.7, 64bit, not sure if that is a factor.

3113Project commented 5 years ago

I disabled "Action Command Prompt" then it work.

jneilliii commented 5 years ago

Can you send me the link to that plugin's homepage?

ygtc commented 5 years ago

Action Command Prompt comes with octoprint which created by Gina Häußge.

I can send you to ss about plugin.

actioncommand

I hope you figured it out error :sweat_smile:

:eyes: :eyes:

ygtc commented 5 years ago

Btw i tried also Action Command Prompt to disable but still not working for me:/

Just in case maybe you found conflict with Action Command Prompt and this issue might be solved.

kabaur commented 5 years ago

Hi, I also had no luck with disabling Action Command Prompt.

jneilliii commented 5 years ago

Been tied up at work. Are any of you guys using Chrome? Can you try in a new incognito window to see if is the same thing? Is anyone willing to do a screen sharing session with me so I can look specifically at their implementation and do some debugging since I am still unable to reproduce this issue you are experiencing.

Pheelix commented 5 years ago

After Disabling/Uninstalling System Command Editor my Sidebar Ordering worked again. I think this is the plugin causing the problem. Someone want to try disabling/uninstalling System Command Editor and see if it fixes it for them?

ygtc commented 5 years ago

I am not using System Command Editor but i tried to disable/uninstall Custom Control Editor. No chance :disappointed:

Still same.

Pheelix commented 5 years ago

I recommend disabling each plugin one by one until it does work. That is what I did. It is a slow process due to restarts, but it is the only way I can think of to find out what plugin is conflicting.

NovaViper commented 5 years ago

@jneilliii For me, the Conslidate Temp and Control plugin was what caused the Dragon plugin to stop functioning on the sidebar.

JdeV987 commented 5 years ago

After disabling "System Command Editor", DragonOrder worked again on the sidebar menus..

jneilliii commented 5 years ago

Ok, I see the reason for this. It appears that the System Command Editor plugin is also implementing a jquery.ui.sortable library, which is probably conflicting with this plugin's version. I assume any of the other plugin's that also implement a different version would cause this. The Consolidate Temp and Control plugin changes the spans classes used by this plugin to identify the sidebar panels. In either case, the DragonOrder plugin does not need to be loaded for the ordering to work properly once you've re-ordered with the plugin. So disable the conflicting plugins and enable this one, order the things the way you want them and then disable this plugin and enable the others.

kabaur commented 5 years ago

With the new update from SystemCommandEditor by Salandora (version 0.3.3) it now works. Thanks @jneilliii for the great work!

jneilliii commented 5 years ago

Glad to hear. Thanks to @Salandora for merging my pull request.

Salandora commented 5 years ago

@jneilliii thanks for the PR and also glad to hear that it solved this issue.