search

jneilliii / OctoPrint-FloatingNavbar

11 stars 0 forks source link

[Feature Request] Turn Off "Got To Top" arrow #12

Closed KenLucke closed 3 years ago

KenLucke commented 3 years ago

Any chance you could implement this, now that we've narrowed down that it's your plugin? :)

https://github.com/OctoPrint/OctoPrint/issues/4010

jneilliii commented 3 years ago

Yes, I can make this an optional component when I get some spare time.

jneilliii commented 3 years ago

Should be set with the above commit @KenLucke. You can test by using the URL below in Plugin Manager > Get More > ...from URL and clicking Install. Once installed go into settings and set the Scroll to Top height to 0 and that should disable it.

https://github.com/jneilliii/OctoPrint-FloatingNavbar/archive/rc.zip
KenLucke commented 3 years ago

Seem to work fine. Couldn't just make it "On/Off," could you? [grin] I'm ass/u/ming that the figure is the minimum height the window needs to be scrolled before the arrow becomes active?

jneilliii commented 3 years ago

That is correct, so you could technically put in a large number rather than 0 to also have it not show up. I think it makes more sense to be configurable rather than just an on/off that way anyone can adjust based on their own resolution/text scaling, and monitor orientations. Previously I was just using a 10% of height value.

KenLucke commented 3 years ago

It works either way, so I am happy... thanks for the quick fix!