jneilliii / OctoPrint-FloatingNavbar

11 stars 0 forks source link

Wraps lines when out of room #3

Closed nionio6915 closed 6 years ago

nionio6915 commented 6 years ago

If there is too much information to the navbar, the lines will wrap and new height of the Navbar will obscure the tabs at the top.

In my case, loaded plugins in the Navbar are PSUControl, Octolapse, Estop, Navbar Temp and TouchUI, screenshot here- https://imgur.com/a/w4X2W

Toggling Full Screen navbar with alter the width of the navbar information also.

jneilliii commented 6 years ago

That's more of an issue with octoprint itself and not my plugin.

foosel commented 6 years ago

@jneilliii I disagree. That the navbar wraps, yes, that is an OctoPrint issue. That the wrapped navbar when floated due to your plugin being installed then makes parts of the interface inaccessible, that's an issue with your plugin.

tldr:

image

sbts commented 6 years ago

As for octoprint wrapping. I think thats a fair behaviour if there is more information to be displayed than fits on a single line.

There is only one other rational way to handle that. Continuously scroll the content but then depending on the content that may prevent access to elements when required.

To keep this in perspective not everyone is viewing on wide screens with high resolution. So wrapping could happen even on a fairly standard screen

jneilliii commented 6 years ago

Sorry guys, missed the fact that this was on the floating navbar plugin, thought it was a comment to one of my power plug plugins. I'll adjust the offset based on navbar height insteadof being hard coded.

jneilliii commented 6 years ago

This issue should be fixed with latest version 0.3.0.

sbts commented 6 years ago

@jneilliii thanks for that.