search

jneilliii / OctoPrint-FloatingNavbar

11 stars 0 forks source link

[Bug] Does not affect Dashboard plugin in Full Browser Window mode. #7

Closed KenLucke closed 4 years ago

KenLucke commented 4 years ago

When using the Dashboard plugin in Full Browser Window mode, the settings do not seem to affect it at all. When in Normal mode, or Full Screen mode, it works normally. This is the case with or without the webcam enabled.

Here are two screenshots with the settings at a ridiculously high 200 for emphasis. The first one is in Normal Mode, the second one is in Full Browser Window mode.

Normal Mode

Full Browser Window Mode

jneilliii commented 4 years ago

And without this plugin installed what does it do? Please also open ticket with the dashboard plugin and link back to here, as this may be a problem on that end since full screen mode is a feature it adds.

KenLucke commented 4 years ago

And without this plugin installed what does it do? Please also open ticket with the dashboard plugin and link back to here, as this may be a problem on that end since full screen mode is a feature it adds.

It works normally in all tabs except the Dashboard. I haven't tried uninstalling Dashboard, as I'm in the middle of some multi-day prints and can't afford to restart OctoPrint and lose them.

I will see if I can open a Dashboard ticket and link back.

jneilliii commented 4 years ago

@KenLucke is this issue actually Themeify related maybe? I just tested Full Browser mode in the default appearance without Themeify enabled and the issue doesn't appear to be there for me.

image

KenLucke commented 4 years ago

I thought In had disabled Themeify in my testing before filing an issue, and it made no difference, but I will check again after my printer(s) are free.

jneilliii commented 4 years ago

No need, I think I see what you're saying now. If I set the offset value to a high number the full browser mode is still jammed up to the top of the navbar. I'm checking into it.

jneilliii commented 4 years ago

Just released version 0.3.2 that resolves this issue for you @KenLucke. Let me know how it goes.

KenLucke commented 4 years ago

Looks good. I lost the webcam when updating from OP, but rebooting the Pi brought it back. Just in case others have the same issue.

thanks for your work.

jneilliii commented 4 years ago

Noticed an issue with the scroll to top button, so I just pushed a new version. Sorry about that.

KenLucke commented 4 years ago

Still having issues with the webcam showing up. If I have two browser windows open with the same OctoPrint instance, only one of them will show the webcam. If I refresh one browser window/tab, the webcam shows up in the other one, but it does not when the refreshed tab reloads.

github doesn't allow videos, so I have a link to a video of me doing this on dropbox: https://www.dropbox.com/s/lbfrwkv2womwchj/screencast%202020-05-30%2020-15-49.mp4

jneilliii commented 4 years ago

That sounds like a dashboard plugin issue. Does it not do that when this plugin is disabled? I'm confused why my plugin would do anything to break the webcam. I do know that you have to run some internal functions in octoprint for the webcam to load and if that's not being done in the full browser mode that might cause this issue.

KenLucke commented 4 years ago

All I know at this point is that it didn't used to do that in the previous version I have running on the other printer. I'll try disabling.

KenLucke commented 4 years ago

OK, you are correct, disabling FloatingNav Bar the problem still exists.