jneilliii / OctoPrint-JogWheelControl

2 stars 0 forks source link

z-axis controls do not work anymore #5

Closed Rednax74 closed 3 months ago

Rednax74 commented 3 months ago

After the last update the z-Axis buttons do not work anymore. x- and y-axis controls work as well as the home buttons. Jog Wheel Control (1.0.0)

jneilliii commented 3 months ago

please check the terminal tab after pressing the button, it's sending the command for me to move z.

image

Rednax74 commented 3 months ago

I checked it already, for x/y the commands are visible, for the z axis not. And if I disable your plugin, the standard z-axis controls work. But I'll double check.

jneilliii commented 3 months ago

Might have to get you to open your browser's developer tools and look for errors on page load or on z button clicks since this plugin is mostly javascript programming.

Rednax74 commented 3 months ago

I am using Opera by the way, if I press the z-axis buttons this error message is shown in the concole: Screenshot 2024-08-26 084732

BeriBGood commented 3 months ago

For me it is working for Z, but not for Y Console shows this: image

(Firefox)

jneilliii commented 3 months ago

Ok, so in both cases it's related to distance variable in the code, and that is being used to figure out if the axes is inverted or not I think. In all my testing I didn't ever have this issue, so it could be a timing problem, or a missing dependency to the printer profile information.

@BeriBGood what browser are you using? never mind, I see you added it to your post, sorry for missing that.

BeriBGood commented 3 months ago

Firefox 129.0.2 (64-bit) Edge Version 128.0.2739.42 (Official build) (64-bit) also has the error for Y (X, Z and Homing work fine)

image

The previous version of the plugin worked fine for me. Something in the new version broke, if that helps you restrict the scope of the debugging.

Rednax74 commented 3 months ago

Since my z-axis is inverted, maybe it is related to this setting. I'll test it without setting the z Axis to inverted maybe this works (If I can find the settings for that again :-) )

Rednax74 commented 3 months ago

ok, I removed in the printer profile the invertion flag and without this being set it works again. In the previous version I am relatively sure that it worked also for the inverted z-axis. Maybe it is a spelling error of the parameter?

jneilliii commented 3 months ago

Thanks, it does look like in the previous version I was defaulting those values in the function to null, and that may actually get past this random issue. I'll see about making that change tonight and release a new version and get you guys to test for me.

jneilliii commented 3 months ago

I've made some tweaks to the javascript side related to axes inversion. Could you guys please test for me prior to release? You can go into plugin manager > get more, copy/paste the URL below in ...from URL and click install.

https://github.com/jneilliii/OctoPrint-JogWheelControl/archive/refs/heads/master.zip
BeriBGood commented 3 months ago

Thank you, it works for me in all directions now.

Rednax74 commented 3 months ago

Thanks a lot, it works also for me!

jneilliii commented 3 months ago

Thanks for the confirmation, new release has been published and is now live. There's nothing you guys will need to do because you'll already have the newer version installed.