jneilliii / OctoPrint-M117SpeechSynthesis

5 stars 1 forks source link

Test doesn't work #1

Closed joeynuggetz closed 6 years ago

joeynuggetz commented 6 years ago

Tried in Chrome and in Edge. Voices listed but no audio. Firefox does not list any available voices.

jneilliii commented 6 years ago

Are there any errors in the browser's console?

markwdickson commented 6 years ago

I found that the "Test" button is disabled when first enabling the plugin. When you click the checkbox "Enable Speech" you must first click the "Save" button at the bottom to update the changes. THEN go back into the settings again and the Test button will be active. Could this be your problem?

I was going to suggest making the Test button active upon clicking the "Enable Speech" checkbox rather than having to Save the settings and re-enter the dialog again. I too thought something was broken before I realized it was an order of events thing.

jneilliii commented 6 years ago

That is actually how it's currently programmed. I have an idea to get around that implementation for a future release, but haven't had the time to program and test. Disabling the test button was a workaround to force a save because of what I think is a knockout binding issue on my end.

jneilliii commented 6 years ago

Logic updated in latest release 0.4.0 addressing @markwdickson concern, closing since no response from @joeynuggetz